Git Product home page Git Product logo

Comments (13)

cdelmonte-zg avatar cdelmonte-zg commented on September 23, 2024 1

@gmarzot do you have some news? The version 2 of the plugin was released yesterday, maybe is the problem solved in the new version?

from bitbucket-push-and-pull-request-plugin.

arohithr8 avatar arohithr8 commented on September 23, 2024 1

Hi I'm facing same issue but for feature branches repo:push to feature events do not trigger builds.

Can you help on how to solve it.

Plugin-Version: 2.0.0
Jenkins-Version: 2.176.1

jenkins log:

Should schedule job : true and (polling result has changes false or is pull request false)

It's working fine for Master and PR.

from bitbucket-push-and-pull-request-plugin.

cdelmonte-zg avatar cdelmonte-zg commented on September 23, 2024 1

@vweng @arohithr8 please, can you test the bitbucket-push-and-pull-request-2.1.0-beta-3 version and let me know if it works for you? Thank you

from bitbucket-push-and-pull-request-plugin.

vweng avatar vweng commented on September 23, 2024 1

@cdelmonte-zg Thanks for adding the triggerAlsoIfNothingChanged option, I can confirm it works with the following settings:

bitBucketTrigger([[$class: 'BitBucketPPRRepositoryTriggerFilter', actionFilter: [$class: 'BitBucketPPRRepositoryPushActionFilter', triggerAlsoIfNothingChanged: true, triggerAlsoIfTagPush: false]]])

from bitbucket-push-and-pull-request-plugin.

cdelmonte-zg avatar cdelmonte-zg commented on September 23, 2024

Might you provide more context?
Thanks

from bitbucket-push-and-pull-request-plugin.

gmarzot avatar gmarzot commented on September 23, 2024

not sure what additional info is needed. I ended up hacking the code to get it to work for us.
diff attached. I was not able to fully inspect the changes tracked by the event in the plugin code.. but it appeared to consider them "INSIGNIFICANT" despite the event being caused by a substantive merge/push to origin/master

I dont think my code change is correct but am not sure how this plugin determines the 'changes' metric from the bitbucket webhook payload.

repo_push_diff.txt

from bitbucket-push-and-pull-request-plugin.

cdelmonte-zg avatar cdelmonte-zg commented on September 23, 2024

Hi @gmarzot,
I'll check the diff, thank you for sharing it.

One question, did you try to configure the push allowed branches simply with 'master' instead than '*/master'?

There were some changes in the plugin to allow regex etc. in the style of the git plugin and the screenshot in the documentation was updated only today...

from bitbucket-push-and-pull-request-plugin.

gmarzot avatar gmarzot commented on September 23, 2024

I believe we tried it both ways... but it looked like the allowed branch test was passing fine.

that line was coming back false
boolean hasChanges = pollingResult.hasChanges();

I don't know why pollingResult is in the picture at all.. isn't all the necessary info in the webhook payload?

from bitbucket-push-and-pull-request-plugin.

cdelmonte-zg avatar cdelmonte-zg commented on September 23, 2024

Hi @gmarzot, pollingResult.hasChanges() method isn't part of the plugin, but it's coming from here

We are using it on the push events, to be sure, that we are triggering a job only in case of a change in the related repository/branch.

To be sure that changes between remote and local branch exist, you could check the diffs between the pertinent remote branch on the bitbucket cloud server and the correlated local branch on the Jenkins server using git status or something similar from the shell of the server where Jenkins is running on...

Let me know

from bitbucket-push-and-pull-request-plugin.

vweng avatar vweng commented on September 23, 2024

We're facing exactly same issue. Please remove the pollingResult.hasChanges() check, as it always return false with feature branch pushes. It's working fine for master and PR though.

Plugin-Version: 2.0.0
Jenkins-Version: 2.190.1

from bitbucket-push-and-pull-request-plugin.

vweng avatar vweng commented on September 23, 2024

So this is same bug as #54

from bitbucket-push-and-pull-request-plugin.

arohithr8 avatar arohithr8 commented on September 23, 2024

@cdelmonte-zg Thank you, after updating to version 2.2 and adding triggerAlsoIfNothingChanged: true as @vweng mentioned above it's working as expected.

from bitbucket-push-and-pull-request-plugin.

cdelmonte-zg avatar cdelmonte-zg commented on September 23, 2024

Thank you all, I updated just now the readme file.

from bitbucket-push-and-pull-request-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.