Git Product home page Git Product logo

Comments (12)

XhmikosR avatar XhmikosR commented on May 21, 2024 1

A config option will be needed that for sure.

I just feel an image makes things more official in a feed. It's the only thing I miss from my old RSS custom solution I was using.

from jekyll-feed.

pathawks avatar pathawks commented on May 21, 2024

Yes, love it. But we would need to make sure that such an image actually exists in the site first.

Is there a way to do this without just config 🎄?

Also, perhaps #2 should be sorted out first, before diving too deep into these features?

from jekyll-feed.

XhmikosR avatar XhmikosR commented on May 21, 2024

I don't think you can do that since the URL is the remote one. So one might upload it at a later time. Also note that this only seems to work with IE and Firefox that I have tested; Chrome doesn't show this without an extension.

Since this is an optional element, I'd say whoever is using it knows what to do with it :P

What I think we could have is a check for the dimensions since the specs have a limit there.

from jekyll-feed.

pathawks avatar pathawks commented on May 21, 2024

I don't think you can do that since the URL is the remote one.

I just mean we shouldn't start including an <image> in all feeds; there would need to be either a setting or something to specify the image URL, or a check for a specific file to be used as the image if it existed.

from jekyll-feed.

XhmikosR avatar XhmikosR commented on May 21, 2024

Oh, that. Sure.

But IMO all image sub-elements should be mandatory so we should check for all of them.

from jekyll-feed.

pathawks avatar pathawks commented on May 21, 2024

In Atom, this is called <logo>, and there is also <icon> for favicon type images.

(Just leaving notes for myself.)

from jekyll-feed.

ElMassimo avatar ElMassimo commented on May 21, 2024

Any updates on this one now that #2 is resolved?

from jekyll-feed.

XhmikosR avatar XhmikosR commented on May 21, 2024

That is a post image though. Not a site wide one. Does atom support image
in root?
On Mar 23, 2016 00:18, "jekyllbot" [email protected] wrote:

Closed #14 #14 via #104
#104.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#14 (comment)

from jekyll-feed.

pathawks avatar pathawks commented on May 21, 2024

@XhmikosR Do you know of a feed reader that displays a per feed image? How would this be used?

from jekyll-feed.

XhmikosR avatar XhmikosR commented on May 21, 2024

I know Firefox shows the image to the right. But that was with RSS. Not sure if atom supports it. The original request was from when this repo was RSS.

from jekyll-feed.

pathawks avatar pathawks commented on May 21, 2024

FWIW, WordPress adds a square 32px icon to Atom feeds.

I am not sure what this would be used for and I can't think of any way to add support for it without adding a config option (:christmas_tree:), so I am not enthusiastic about the idea.

from jekyll-feed.

inetbiz avatar inetbiz commented on May 21, 2024

Is this implemented yet?

from jekyll-feed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.