Git Product home page Git Product logo

Comments (10)

Ch4s3 avatar Ch4s3 commented on May 30, 2024

@jjk-jacky That's my commit, so I'll take a look and see if I can reproduce and fix the issue.

from classifier-reborn.

parkr avatar parkr commented on May 30, 2024

Thanks @Ch4s3!

from classifier-reborn.

Ch4s3 avatar Ch4s3 commented on May 30, 2024

I can't reproduce the error with gsl 1.16 on OSX yet, but a simple fix would be to add a check for GSL here and using the old code for GSL vectors and the new code for vector arrays. I'm not sure I like that though, so I'm going to keep testing and think it over.

from classifier-reborn.

parkr avatar parkr commented on May 30, 2024

I'll let you take the lead on this one, @Ch4s3. Thanks!

from classifier-reborn.

jjk-jacky avatar jjk-jacky commented on May 30, 2024

I don't know much about all this, but looking into it a bit, I found this issue which seems to indicate, as the error I reported, that the GSL::Vector object doesn't have a method reduce -- Though I'm not sure why you can't reproduce it then, if using GSL?

Anyways, I'd guess then that in both linked commits it might indeed be needed to checked whether it is a GSL::Vector used, and if so keep the use of sum.

from classifier-reborn.

Ch4s3 avatar Ch4s3 commented on May 30, 2024

This is interesting, it seems that GSL::Vector supports .map and .collect 555d4a3 was about removing that monkey patch. I'm using a check for GSL and .collect to get the sum. the pull is here

from classifier-reborn.

FredrikWendt avatar FredrikWendt commented on May 30, 2024

In https://github.com/FredrikWendt/jekyll-issue I have this problem in a Docker environment (so it would be easy to reproduce).

from classifier-reborn.

parkr avatar parkr commented on May 30, 2024

@FredrikWendt, are you using rb-gsl?

from classifier-reborn.

FredrikWendt avatar FredrikWendt commented on May 30, 2024

Yes I am. And the above issue only appears when run with classifier-reborn version 2.0.2. In the Docker environment 2.0.3 is installed now. I won't spend more time trying to fix this - I included a patch which I ran on /var/lib/gems/1.9.1/gems/classifier-reborn-2.0.2/lib/classifier-reborn/lsi/content_node.rb before invoking jekyll.

from classifier-reborn.

parkr avatar parkr commented on May 30, 2024

2.0.3 should fix this.

from classifier-reborn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.