Remove enable_threshold config from Bayes classifier about classifier-reborn HOT 4 OPEN

I will add #47 here for reference.

from classifier-reborn.

Yeah, I remember #47 pretty well. I agree that it's a bit broken, but I'd like to fix it rather than removing it. Perhaps we can fix it for 3.0, and make the false flag work correctly.

Looking at this line:
result = nil if score < @threshold || score == Float::INFINITY if threshold_enabled?

I feel like we do need a fix. I'm not opposed to cleaning up the API though.

from classifier-reborn.

I think you can add a label like 3.x so that we can resurface it when the times comes.

I agree that it's a bit broken, but I'd like to fix it rather than removing it.

The issue I described, if it is fixed, then I think enable_threshold will become completely irrelevant that can be achieved by setting the default threshold to Infinity. However, for the sake of backward compatibility, we can perhaps keep it for 2.x.

from classifier-reborn.

Agreed. Let's discuss this further once we make plans for 3.0

from classifier-reborn.