Comments (13)
Hello, thank you!
There have been some changes since previous milia versions. It is best to
use the milia generators to install milia for a new Rails 4 application,
then compare what needs to changing in the older app.
In particular, milia now requires an additional boolean in the users table;
the generator adds the following to the
db/migrate/xxxxxx_devise_create_users.rb:
# milia member_invitable
t.boolean :skip_confirm_change_password, :default => false
t.references :tenant
Milia is expecting this to be false for invited members, so that they will
be sent to a create password form. For new organizational sign ups,
,however, milia sets this to true, since the sign-up form had a
user-generated password. Milia generates a password for invited members,
because devise requires a password to create a user record; but with
skip_confirm_change_password false, the user should be directed to a create
password form. The intent is for all this to be automatic.
On Thu, Jan 9, 2014 at 11:52 AM, Alan Ruth [email protected] wrote:
Thanks for your work on this! I am using it for a couple of projects now.
When I add a new member for a tenant, a password is being generated and
used for the user creation for devise. The email goes out with a
confirmation link. When they click on the link, it automatically logs them
in and puts them on the welcome screen.I also see this in the code and of particular interest is the
change_or_confirm_user and line 38: if (
@confirmable.skip_confirm_change_password || @confirmable.valid? )In the situation I described, I would have thought this would have
returned false and thus would hit the else statement on line 40. However it
appears to be resulting in true and executing the do_confirm (which logs
them in automatically). Yet my new member never gets to set up their own
password via a show view that I build and your update method.I may not be following the code correct but any guidance would be
appreciated.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19
.
from milia.
Thank you for the response. I had done as you suggested in the read.me and used the generators to create the initial app (I am on beta 3 too) . I have since taken it and customized it. As such, I do have the boolean that you speak of on the user model. I just tested this again. The database does save false in the field when I create a new member. I then use the confirmation link found in the email and yet it still does the automatic sign in. Maybe I missed something...
from milia.
perhaps. When I do the basic install as described in the wiki (or as in
doc/sample.sh), it does not exhibit the behavior you described. So I think
something has been altered in your code. If you provide me with a github
viewing for your code, I might be able to find something that's amiss. But
right now, there's not enough information to troubleshoot the issue.
On Sat, Jan 11, 2014 at 1:58 PM, Alan Ruth [email protected] wrote:
Thank you for the response. I had done as you suggested in the read.meand used the generators to create the initial app (I am on beta 3 too) . I
have since taken it and customized it. As such, I do have the boolean that
you speak of on the user model. I just tested this again. The database does
save false in the field when I create a new member. I then use the
confirmation link found in the email and yet it still does the automatic
sign in. Maybe I missed something...—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-32108475
.
from milia.
Hello,
I am seeing this problem as well with your sample application. I can sign up as a tenant, confirm the account, send an invite, but when I confirm the invite I am not sent a password and dumped directly to the welcome page. When I click on reset your password I get "uninitialized constant Milia::PasswordsController". Anyways, thanks for all your work on this. I am trying to avoid using Postgres schemas or seperate databases in my app and this will be the way to go if I can get it working correctly.
Edit: One thing I have noticed which is weird is that I can invite members after I confirm. I think it the member invite process is setting the member up as a user for some reason.
from milia.
working on this; i'm also adding improved debug/info logging (to help with
troubleshooting) and a callback for successful authenticate_tenant! These
will soon appear in the next -beta6; for right now, they're being testing
in the edge branch "newdev".
On Fri, Jan 24, 2014 at 7:24 AM, xman2000 [email protected] wrote:
Hello,
I am seeing this problem as well with your sample application. I can sign
up as a tenant, confirm the account, send an invite, but when I confirm the
invite I am not sent a password and dumped directly to the welcome page.
When I click on reset your password I get "uninitialized constant
Milia::PasswordsController". Anyways, thanks for all your work on this. I
am trying to avoid using Postgres schemas or seperate databases in my app
and this will be the way to go if I can get it working correctly.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-33231341
.
from milia.
Beta-5 now has the improvements and is ready for usage. Please try working with it. thanks!
from milia.
Hi,
I know this issue is closed, but, I don't understand how it is supposed to behave and in the sample app I am seeing the behaviour described above:
- create clean sample app
- sign up for organisation
- invite member
- go to member confirmation link and it asks me to sign in, but, I have no idea what the password is
How to get members to go to the password page? Or even to get them logged in automatically?
from milia.
It's been a while since I've looked at this. But yes, the ORGANIZER is the
first one to sign up for his organization, at that time the ORGANIZER
creates a password once he has activated his link. To get other members
into the same organization, he then clicks a link to invite new MEMBER,
entering the new MEMBER's email into the form. The system then sends an
activation email to the member, who then needs to click the activation
link. That should take the MEMBER to a page requesting MEMBER to create a
password. once that is submitted, then thereafter MEMBER can enter system
via the sign-in page/link.
The confirmation link should NOT be directing to the sign in page.
On Mon, Jun 13, 2016 at 7:22 PM Phil Smy [email protected] wrote:
Hi,
I know this issue is closed, but, I don't understand how it is supposed to
behave and in the sample app I am seeing the behaviour described above:
- create clean sample app
- sign up for organisation
- invite member
- go to member confirmation link and it asks me to sign in, but, I
have no idea what the password isHow to get members to go to the password page? Or even to get them logged
in automatically?—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#19 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAZDDBSWmfgi0iu9QgG3B8NVRjLPbiU9ks5qLhBsgaJpZM4BYqYI
.
from milia.
Ok...that's definitely NOT what's happening (and the organizer creates his own password on the signup form).
I followed the doc/sample.sh to create the sample app, and I double checked and everything seems right.
How to debug why this is sending me to a login page?
from milia.
owner doesn't create it on the signup form; password creation occurs after
activation.
On Mon, Jun 13, 2016 at 7:33 PM Phil Smy [email protected] wrote:
Ok...that's definitely NOT what's happening (and the organizer creates his
own password on the signup form).
I followed the doc/sample.sh to create the sample app, and I double
checked and everything seems right.
How to debug why this is sending me to a login page?—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#19 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAZDDB-rYuasIKxMePrHI2ZBHZe-JGcwks5qLhLcgaJpZM4BYqYI
.
from milia.
Hey guys.
I am currently experiencing the same issue. When inviting a new member, an activation link is created (as expected). If I follow the link to activate that particular users account, I am presented with the login form. The user is successfully confirmed but has no opportunity to create their own password etc.
I thought this was intentionally left out of Milia's out of the box offering and I would need to extend on it myself but it seems like it may be an issue?
On a side note, I am really enjoying working with Milia so far, thank you!
from milia.
To be honest, I solved this by using cortexinsight's fork. It fixed the problem (even for the sample app). Now everything works as expected. By switching to that fork I also discovered that my confirmations were never right... they never auto-logged in the tenant own, but presented a login screen. (same thing happens in the clean sample app)
from milia.
Having this same issue. I Was going to override the devise confirmation controller, but realized that milia is already doing that. Any ideas?
from milia.
Related Issues (20)
- Email address gets lost while inviting a new user HOT 1
- Upgrade path from 1.2.x to 1.3.x HOT 2
- Complare to ErwinM/acts_as_tenant HOT 1
- Setting tenant with JWT. Works with Thread.current_tenant? HOT 2
- Milia::Control::InvalidTenantAccess in MembersController#create no existing valid current tenant HOT 2
- can't install on rails 5.1 HOT 17
- rails 5 sign up raise error "Tenant must exists" HOT 1
- Milia gem installation problem HOT 33
- Can't install milia. plz help. HOT 3
- Can't create table using command rake db:migrate
- Can't install on Rails 5.1.3 HOT 2
- Tenant models with String primary key(ID) instead Integer(ID) - Not working HOT 3
- Error installing milia "Could not find generator 'milia:install'. Maybe you meant 'devise:install', 'migration' or 'mailer'" HOT 3
- Cannot install properly on Rails 5.2.1, uses depreciated "before_filter" HOT 3
- NoMethodError in Milia::RegistrationsController#create HOT 3
- Generator creating references which should be deleted? HOT 1
- [register user/org] tenant create failed - Tenant must exist HOT 3
- Rails 6.0.1 undefined method `skip_before_filter' for Milia::RegistrationsController:Class HOT 8
- Milia gem doesn't uploaded HOT 2
- Future of milia HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from milia.