Git Product home page Git Product logo

Comments (7)

jeevatkm avatar jeevatkm commented on June 1, 2024

@ofa- Thanks for the proposal. I will have a look.

from replywithheadermozilla.

ofa- avatar ofa- commented on June 1, 2024

for the first item, you may check ofa-@b2768c26
(part of branch ofa-:uniformize+simplify_radiogroups)

from replywithheadermozilla.

ofa- avatar ofa- commented on June 1, 2024

Here is what it looks like on Ubuntu, with simplified styling internals.
(in this screenshot, please ignore the fact that I also moved the locale/lang button)
image

from replywithheadermozilla.

jeevatkm avatar jeevatkm commented on June 1, 2024

It seems you're working on this otherwise please let me know. I have just merged my work into master. Please branch out fresh from master.

Please find my comment/suggestions:

  • For Point No. 1 - please go ahead for string changes
  • For Point No. 2 - It is important to provide backward compatibility. It can be achieved via fallback approach. First look for date.timezone if not found then look for date.format.
  • For Point No. 2 - This is gonna be a issue date.style => date.format. For now we have to halt this change or pick some new name for setting.
  • For Point No. 3 - For now we have to halt to this improvement. Its a new UI appearance and settings. It major step. We have to give it try on separate branch; see how its gonna look then we have to decide otherwise we have to postpone/skip this item.

Mostly existing users will be upgrading first (backward compatibility is important), I do not want spoil their experience with significant breaking changes. UI improvements is okay but configuration breaking might affect a lot For. eg: using date.style => date.format we have to choose some new settings name.

from replywithheadermozilla.

jeevatkm avatar jeevatkm commented on June 1, 2024

@ofa- May I expect PR per above comments?

from replywithheadermozilla.

ofa- avatar ofa- commented on June 1, 2024

@jeevatkm point 1: see #40

from replywithheadermozilla.

ofa- avatar ofa- commented on June 1, 2024

considered done (point nĀ°1 done, plus internal cleanup done)
other suggested changes dropped, as they would break existing conf or require fallback implem.

from replywithheadermozilla.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.