Git Product home page Git Product logo

Comments (8)

dcousens avatar dcousens commented on July 17, 2024 3

I vote the AMD exports are removed entirely; then this is a non-issue.

from classnames.

stevemao avatar stevemao commented on July 17, 2024 1

probably better to keep it all lowercased classname.

from classnames.

anilanar avatar anilanar commented on July 17, 2024 1

Assuming most people have now switched to ES imports, why doesn't classnames have an ES6 main file using module key in package.json? module.exports can be mapped to ES in 2 different ways (wildcard import and default import) which causes issues if used in a complicated scenarios with typescript, babel, node etc.

from classnames.

AndyOGo avatar AndyOGo commented on July 17, 2024

Okay I investigated the issue more carefully. As it turns out it is quite simple.
Just use the CommonJS module key:

import classNames from 'classNames';

I leave it open, because inconsistency in module names for different module syntax is a bad practise.

from classnames.

dcousens avatar dcousens commented on July 17, 2024

probably better to keep it all lowercased classname.

Agreed, but that is now a massive breaking change for anyone using bower.

from classnames.

AndyOGo avatar AndyOGo commented on July 17, 2024

Agree, it is definitely a breaking change. So I would put it in a Major release.

from classnames.

a932455223 avatar a932455223 commented on July 17, 2024

The issue help me solve my problem.Thanks.

from classnames.

dcousens avatar dcousens commented on July 17, 2024

Probably resolved by #150, closing in favour of that (unless it isn't, in which case, re-open)

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.