FileChangeReloadStrategy thread dies on Exception: no error handler about cfg4k HOT 3 CLOSED

I will for sure add the reloadErrorListener feature (almost for sure today). I actually didn't think about configuration mistakes etc.

This will be the signature of the function inside the ConfigProvider interface.

    /**
     * Adds a reload listener that will be called when there is an exception in the reload process.
     */
    fun addReloadErrorListener(listener: () -> Unit)

For the logging... I might do it but that is not one of my priorities right now. With the experience I have seen that the logging for a (I'd say) relatively small library like this one adds nothing but overhead for the real application log so I decided to go with the listeners approach where each one can react how they want to the different events like reload, error reloading etc.

from cfg4k.

So I have added the listener, it is currently in master.

    /**
     * Adds a reload listener that will be called when there is an exception in the reload process.
     */
    fun addReloadErrorListener(listener: (Exception) -> Unit)

This is the final signature and for the logging you can open a new issue to be discussed there, please!

from cfg4k.

This is the final signature and for the logging you can open a new issue to be discussed there, please!

No need I think... I agree with your idea that logging is unnecessary and listeners are the way to go. Thanks!

from cfg4k.