SlowQueryListener always shows time as 0, QueryLoggingListener shows correct time. about datasource-proxy HOT 7 CLOSED

@binakot wrote a wiki page for that.
https://github.com/ttddyy/datasource-proxy/wiki/Logging-slow-queries

from datasource-proxy.

Regular query logging listeners write out query after execution has finished. So, it has time populated.
For slow query loggers, it writes out query when it passed threshold time. For example, if a query takes 10min and threshold time is set to 1min, the slow query logger prints out query when it passed 1 min while query is still running.

Currently, slow query logger is not updating execution time(elapsed time). So, it'll always show 0 in time.
I'll update to populate the time with current elapsed time. So, for slow queries, it will show threshold time(or threshold time +alpha based on when scheduler execute the thread) in time field.
(1min for above example).

Meanwhile, you can update slow query class like this to achieve same behavior:

SLF4JSlowQueryListener slowQueryListener = new SLF4JSlowQueryListener(...) {
    @Override
    protected void onSlowQuery(ExecutionInfo execInfo, List<QueryInfo> queryInfoList, long startTimeInMills) {
        execInfo.setElapsedTime(System.currentTimeMillis() - startTimeInMills);
        super.onSlowQuery(execInfo, queryInfoList, startTimeInMills);
    }
};

from datasource-proxy.

from datasource-proxy.

Ok, so you want to log queries after they have finished which includes actual query execution time, only when they exceed threshold time.

In that case, you can use regular query logging listeners extending them to write query only when it took longer than threshold.

long thresholdInMills = ...
SLF4JQueryLoggingListener listener = new SLF4JQueryLoggingListener(){
    @Override
    public void afterQuery(ExecutionInfo execInfo, List<QueryInfo> queryInfoList) {
        if (execInfo.getElapsedTime() >= thresholdInMills) {
            super.afterQuery(execInfo, queryInfoList);
        }
    }
};
listener.setLogLevel(SLF4JLogLevel.WARN);

from datasource-proxy.

Perfect thanks

from datasource-proxy.

I was confused with that too. Good that I checked closed issues.
An hour ago I was ready to submit a new bug. 😄
I think this information should to add in the documentation with this example.

from datasource-proxy.

@ttddyy Awesome! Thanks!

from datasource-proxy.