Git Product home page Git Product logo

Comments (7)

arsdehnel avatar arsdehnel commented on May 21, 2024 1

Missed that one, sorry about that.

from gitbeaker.

jdalrymple avatar jdalrymple commented on May 21, 2024 1

Just merged into 2.2.0 :)

from gitbeaker.

fewieden avatar fewieden commented on May 21, 2024

So by importing mergerequest model and exposing it to the api I can use it.

Only issue was that there is a first parameter https://github.com/jdalrymple/node-gitlab-api/blob/master/src/Models/MergeRequests.js#L4 projectId which doesn't get used. Is there a reason for it, as all the other endpoints I used don't have it.

from gitbeaker.

arsdehnel avatar arsdehnel commented on May 21, 2024

Seems like exposing that makes sense, otherwise not sure how you'd use it. And I'd agree that the first parameter seems unnecessary. There are some more options for the MR API (like this one https://docs.gitlab.com/ee/api/merge_requests.html#list-project-merge-requests) that need it but the all() call doesn't have an option for it.

from gitbeaker.

fewieden avatar fewieden commented on May 21, 2024

@arsdehnel that one is already in this model https://github.com/fewieden/node-gitlab-api/blob/master/src/Models/ProjectMergeRequests.js#L27

from gitbeaker.

fewieden avatar fewieden commented on May 21, 2024

Do you have an eta when this will be published to npm, as i have some building issues in my automatic pipelines with my fork? Just need to know if I have to workaround it or it will be available in couple of days.

Thanks in advance

from gitbeaker.

jdalrymple avatar jdalrymple commented on May 21, 2024

Yup! Will be publishing today, just need to test that parse change before I publish

from gitbeaker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.