wrong min size: should be Math.min(this.batchSize, records.size) as stated in the log line before about connect-utils HOT 4 CLOSED

@tpeikert Thanks for the issue. Are you running into this with one of my connectors? From a high level I don't think that class is really used that much anymore.

from connect-utils.

Sorry, I see now, that I misunderstood. I think the debug log and the names confused here. :)
The debug log states that the batch size for this run will be calculated and then it states the max batch size and the resords.size, but I see now that List records is the list that gets filled and not drained. Therefor this.size is correct to calculate the batch size.
Again, sorry. I was wrong.
And no, I am reading your code because someone used it for a connector and I'm currently writing something very similar to their connector. Just different enough to have to write it yourself. :)

from connect-utils.

All good. Take a look at this one though. This is the replacement for that class. I need to mark SourceRecordConcurrentLinkedDeque as deprecated. It has a lot more options and has been under heavy use for a while.

https://github.com/jcustenborder/connect-utils/blob/701de970344599e492049a46474dba2124cd8e6d/connect-utils/src/main/java/com/github/jcustenborder/kafka/connect/utils/data/SourceRecordDequeBuilder.java

from connect-utils.

Neat! Thanks.

from connect-utils.