Some identity fields are not saved about rubywarden HOT 5 CLOSED

Hello can you check if it works if you apply #47 ? This might fix this!

from rubywarden.

Thanks for the patch. I've manually patched the lib/helper.rb file as per the commit and its now working.

from rubywarden.

Spoke to soon. Looks like it now saves every field apart from "Social Security Number"

from rubywarden.

i just checked the web-vault code, and it looks like for the other fields it looks for posted-name with first letter upcased, but for SSN it wants all letters upcased, so right now the code generates Ssn, but it wants SSN.

The chrome addon sends "ssn" as the parameter name, I'll cross-check with the web-vault and maybe one needs to special case ssn... :(

edith says: yep, the web-vault sends the keys in a different format, then it expects them back... :( no clue why this is, maybe because of historical reasons...

And changing the helper to this, solves this problem. It probably makes more sense to move this in an app specific helper like: BitwardenRuby::convert_params(p)

class Sinatra::IndifferentHash
  def ucfirst_hash
    out = {}
    self.each do |k,v|
      base = k.to_s
      out[base == "ssn" ? "SSN" : base.ucfirst] = v
    end
    out
  end
end

from rubywarden.

note to myself: need to cross-check with the new web-vault if anything in parameter handling changed there.

from rubywarden.