Comments (6)
I fixed it by doing this.
I've opened #7 to implement the same change here.
from miniver.
Thanks for the report!.
Not sure why this doesn't work; I will look into it.
from miniver.
I understand now. miniver
uses annotated tags to determine the version from git, however instabot
uses unannotated tags.
The difference is essentially that annotated tags store metadata like the person who created it, time of creation etc., whereas unannotated tags do not.
AFAIK the recommended way to tag versions is using annotated tags. I often use unannotated tags to mark work in progress stuff, or to easily move around in the git history, and using these shouldn't affect the version....
from miniver.
the --tags
flag will get git describe
to use unannotated tags to determine a description.
from miniver.
Here's a stack overflow question that discusses this.
I'm pretty convinced that using annotated tags is the Right Way, however even large projects like scikit-learn had this problem during their development, and such projects should still be able to profit from miniver.
from miniver.
I think in the end we shouldn't allow unannotated tags to denote versions.
Miniver is an opinionated tool. If someone's project really wants to use unannotated tags for their versions, then they should modify the source. I can add a section to the README and a patch that can be applied to allow unannotated tags.
from miniver.
Related Issues (20)
- make `install-miniver` offer to tag `v0.1.0-dev` if it detects no tags when installing
- make miniver work with other package layouts
- move CI to GitHub Actions HOT 1
- Clarify relation to setuptools HOT 2
- How does this work when doing `pip install .`? HOT 2
- Installation does not work with 'src' package layout HOT 4
- Make `ver` command work without explicitly providing a package name
- Make running `miniver` with no arguments run `miniver ver` HOT 3
- Add tests and documentation for `version` command
- miniver does not use latest tag for version HOT 6
- miniver refuses to use git's version if the package is not at the repository's root
- Allow distributions that place packages in an arbitrary directory
- Call _static_version and _version from miniver package directory
- Python versions
- `# -*- coding: utf-8 -*-`
- Re-definition of builtin `exit`
- Consistent handling of dev releases HOT 1
- git fails if not owned by user
- Support setup.cfg HOT 2
- [BUG] miniver does not detect "dirty" state when all changes are staged
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miniver.