Add option to change the mobile width about stickynavbar.js HOT 4 CLOSED

There is another problem with the mobile width:

This code:

  if (!options.mobile && windowWidth < 480) {
                $self.css('position', $selfPosition);
  }

Is not at the correct position and can cause the browser to not scroll to the end of the page anymore.

I fixed this by this:

  if (!options.mobile && windowWidth < options.mobileWidth) {
                $self.css('position', $selfPosition);
                return;
            }

I added this directly after:

  var win = $(window),
                windowPosition = win.scrollTop(),
                windowWidth = win.width();

And of course removed the original piece of code. Here are all changes I've made so far: http://pastebin.com/He7TRk3M

I also added a resize event at the bottom as it sometimes didn't work correctly with resizing (weird offset). I couldn't reproduce this anymore so it might be fixed but I didn't put that much time in testing it. I also have no clue of the above fix interferes with the selector code and/or click code as I don't use either.

from stickynavbar.js.

Hi Phyxion, got implemented both mobileWidth option as well as zindex. I also implemented window resize, scroll and ready events on the bottom. Everything is working nicely. Going to fix/implement another points you proposed. Thanks for your involvement.

from stickynavbar.js.

Great! Thanks for the update, looking forward to it 👍

If you are looking for other things to add: the ability to add a class(name) to sticky items (this would also remove the need to add a manual zindex property, as you can just put that in the class then) and an event when it gets stickied and unstickied.

from stickynavbar.js.

Will try to implement sticky/unsticky option as well. Hopefully it will be in the next release. Closing this. Thanks.

from stickynavbar.js.