Filename changed at export when containing the extension itself about whitebox-tools HOT 4 CLOSED

@jfbourdon Thanks for spotting this problem. It results from a use of the 'replace' function to handle paired header/data files for raster formats rather than a proper file path handling solution. This is actually pretty widespread within the WhiteboxTools codebase and as such, until it is resolved, it's a best practice to ensure that file extensions do not appear in either the file name or path.

Note that WhiteboxTools is a completely independent codebase and a separate project from Whitebox GAT, which accounts for their different behaviour in this regard.

from whitebox-tools.

I would gladly try to correct the code, but I can't find in converter_raster_format.rs where this replace operation occur (the lines I found don't seem related to that). I don't have any Rust knowledge but I kind of understand what's going on. Is the replace operation somewhere else around line 174?

from whitebox-tools.

Just found where the magic is happening. I'll make a PR if I ever manage to get it to work!

from whitebox-tools.

Thanks @jfbourdon but because this has implications for several of the supported multi-file data formats, I've just finished refactoring each of the places in the codebase where replace was used to modify a file extension to now use the proper Path method in Rust. See the commit here. If you're becoming familiar with Rust, however, I'd certainly welcome any future commits that you may have for WhiteboxTools.

from whitebox-tools.