Import type only when writing PE file about cecil HOT 6 CLOSED

I'm sorry but I'm completely unsure what you're asking here.

When calling Import, Cecil only imports metadata that doesn't belong to the current module. Now it does this when you actually call Import, but what would be the advantage of delaying it until the file is actually serialized ?

from cecil.

I have the case where a TypeDefinition is created in an assembly, and I create another assembly with an new TypeDefinition that has the first one as base class.
In fact I should need a trick to avoid importing the first TypeDefinition and to have Cecil makes it itself...!

from cecil.

I don't see what's the issue here.

In assembly Foo, you add type A.
In assembly Bar, you modify the base type of type B with the result of Import (A).

And that's about it.

from cecil.

In fact I wonder if Cecil could do the job for the developer (I mean to call the Import method)...

from cecil.

Cecil can not do that at write time, because it would break the principle that in an object graph, everything shares the same module. In that case, the BaseType would have a different module, which is wrong.

So that would mean that to be solved, we would have to modify every setter, such as BaseType to say:

this.base_type = (value.Module != this.Module) ? this.Module.Import (value) : value;

Which ends up being very weird. You set a property with a value and the property ends up with another value, which is unintuitive.

All in all, it's much simplier to let the user do the proper import, especially when it has to import open generic types, which require a context.

from cecil.

OK, you agree.

This issue can be closed.

from cecil.