Add ToString() override to Mono.Cecil.Cil.Instruction about cecil HOT 3 CLOSED

Recomputing offsets on the fly is not going to happen. ToString is just a debug helper. If you need to print the instructions for debugging purpose, you can pay the price of recomputing the offsets.

from cecil.

If it's not going to happen, so be it.

It's a shame though. Debugging (by which I mean stepping though code in a debugger, not tracing) is very difficult without a ToString(). And branch instructions are unreadable without a correct offset (and that means correct all the time, not just after I fixed them).

To be precise, the offsets don't need to be correct per se, as long as Instruction.Previous.Offset < Instruction.Offset < Instruction.Next.Offset. The index in the collection would be just fine for this purpose, but that is not available in Instruction.ToString().

Anyway, I forked the code. Turns out the offset fixup in InstructionCollection is actually very easy and fast. Looks like I might spend a lot of time merging. But I'm sure I'll still win by being able to debug efficiently.

Thanks anyway.

from cecil.

Of course it's easy, of course it's fast, it's just not necessary for a non debugging scenario. Anyway, this enhancement ticket is about getting an Instruction.ToString, which is in now.

from cecil.