Silky doesn't work when django.middleware.gzip.GZipMiddleware is enabled about django-silk HOT 7 CLOSED

Edit your MIDDLEWARE_CLASSES so that GZipMiddleware is before SilkyMiddleware

from django-silk.

As @brmc says, things can go awry with middleware placement. I thought I'd fixed the unicode issues however, so I'll leave this open for now and investigate further at some point

from django-silk.

The unicode issues arent really your fault. Python 2.x is just traditionally terrible with unicode. This same thing will happen with gzipmiddleware just about anytime other apps are analyzing or modifying the response.
Even so, in your case it wouldn't even really make sense to compensate for the encoding/decoding issues because after everything was decoded properly, you'd still have to decompress the gzipped response. It would be much more beneficial for everyone to just insist on proper middleware ordering.

And FWIW, i like where this app is going. it picks up exactly where debug-toolbar leaves off. In the next couple weeks Im going to try and tackle your enhancement requests(no promises though in case i get busy with work). and i'll probably add some tox integration and python 3 support along the way.

good work!

from django-silk.

@brmc

That's a good point and thanks! If you get to the enhancements do let me know if have any questions about anything. Tox especially sounds like a good idea

--Mike

from django-silk.

@mtford90
will do.

in regards to tox, i'll probably start by restructuring your test paths if that's ok with you. similar to, if not exactly like, what I did here: https://github.com/brmc/django-media-helper

the main difference being that, rather than copying the directories during the tests, i'd create a test folder and then symlink to the project from within.

from django-silk.

@brmc

Yeah that's fine with me, the proj organisation is a bit skewed anyhow. We should prob move this to a diff. issue btw ;)

from django-silk.

Closing this as can be solved by middleware placement. Let me know if you're still havin issues tho @melbic

from django-silk.