Git Product home page Git Product logo

Comments (5)

jezdez avatar jezdez commented on August 19, 2024

How does having the request in the context make it easier to overload templates? Can you provide a specific use case?

from django-debug-toolbar.

aaugustin avatar aaugustin commented on August 19, 2024

Shouldn't we just switch from render_to_response to render?

from django-debug-toolbar.

aaugustin avatar aaugustin commented on August 19, 2024

I'm almost sure this change is harmless.

@loic does this resolve your problem?

from django-debug-toolbar.

loic avatar loic commented on August 19, 2024

I'm pretty sure I haven't needed that since contrib.staticfiles landed in core and that debug_toolbar started playing nice with it (i.e. using settings.STATIC_URL).

Replacing render_to_response() by render() might not be sufficient to provide a RequestContext (and hence all the context_processors) to the panel templates because these seem to be rendered with render_to_string().

from django-debug-toolbar.

aaugustin avatar aaugustin commented on August 19, 2024

OK, then I'm going to consider this issue resolved.

from django-debug-toolbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.