Git Product home page Git Product logo

Comments (2)

JustinGrote avatar JustinGrote commented on June 12, 2024 1

I was doing some profiling on this and a couple of the major ones are taking the dependency on the Configuration Module and the Add-Type for EmptyStringAsNullAttribute.

The add-type adds nearly a second to the load time for me, and Configuration module another 500ms. I hand-edited the code to remove these two dependencies and load time dropped down to 300ms cold start which is much more reasonable for something that is going to run "first time" on every load and greatly impacts the users perception of their powershell performance.

from powerline.

Jaykul avatar Jaykul commented on June 12, 2024

I'm not sure I can safely take off the EmptyStringAsNull on the color parameters, but I could easily put that attribute type into the PANSIES assembly and remove the Add-Type call. That would be an easy win, so I will definitely do that.

The configuration module I'm not so sure about. Without it, you need to reconfigure your prompt in your profile on each load (and any time you wanted to change the configuration, you have to edit your profile). Part of the performance problem may be implicit module loading. For best performance, in your profile you should have a Import-Module statement that lists all the modules you need in a single line, in dependency order. E.g.:

Import-Module Configuration, PANSIES, PowerLine

If I wanted to make Configuration optional I would need to rely on documentation, and as you can see from the other issues, we already have problems with people not understanding the insufficient docs.

That is, I could make Set-PowerLinePrompt only call Import-Configuration if the Configuration module is already imported, and then hack the module packaging so that Install-Module still installs Configuration, but Import-Module doesn't implicitly import it... but then people who wanted convenience would have to manually specify the Configuration module in their profile...

from powerline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.