Git Product home page Git Product logo

Comments (4)

stokito avatar stokito commented on August 26, 2024

To be honest it's not so many dependencies declared here and IMO we should get rid off the parent module. It's in fact only complicates a build but gives nothing instead.
All the siblings modules have their own parent poms so we have three levels of inheritance.
It's really hard to maintain: if we update any dependency here this can break any other module without even knowing about.
JFYI: currently on TCK uses the last v1.1 version of the parent pom while all other modules are stuck with v1.0

from javamoney-parent.

keilw avatar keilw commented on August 26, 2024

The Parent POM guides the right usage of plugins and key dependencies like the appropriate JSR version. Beside other things like JAR signing keys which we really don't want to scatter across different projects. There is no 1.1 of the Parent POM, at most a snapshot and therefore using Parent 1.0 sounds perfectly fine. There will be a final 1.1 together with MR1 of the JSR. Not sure if we need a separate BOM, that is probably something to discuss in the mailing list.

from javamoney-parent.

stokito avatar stokito commented on August 26, 2024

Ok, but in javamoney-parent there is no any mention of JSR.
It declares some plugins versions in pluginManagement and contains some other plugins in plugins which makes updating of plugins in jsr354-ri very hard and similar to multiple inheritance: you ether need to override all versions of all plugins or not change anything and even better to remove them and complete use plugins and versions from javamoney-parent .

So if, for example, we want to update maven plugins for jsr354-ri we should do that in javamoney-parent and this will also affects other modules like shelter and TCK. Even more, we have some configuration there.

Also the rules of inheritance in Maven are hardly predictable.
You can build an effective pom for the jsr354-ri-parent and you'll see that there is some mess like we have 5 repositories.

from javamoney-parent.

keilw avatar keilw commented on August 26, 2024

We keep that for a new version.

from javamoney-parent.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.