Additional Module Implementation about jasper-client HOT 6 CLOSED

+1..

from jasper-client.

I agree, and I like this idea a lot. I'll see if I can get to it in the near future; otherwise, it'd be a welcome pull request (if you have time).

from jasper-client.

On further investigation: the problem with this approach is that the ordering of the modules is actually fairly significant.

In Brain.query(), the brain actually tests the input text against the modules in self.modules in order, stopping with the first module that accepts the input. So the order of the modules defines Jasper's preferences.

As an example, consider the input "Hacker News". Both News.py and HN.py would accept this input (as News.py accepts "News", and HN.py accepts "Hacker News"), but this query is clearly aimed at HN.py, so HN.py is placed before News.py in self.modules. In other words: modules with fewer false positives should go earlier in the list.

To specify this behavior, we could add a PREFERENCE attribute to each module and sort by these preferences after loading them dynamically. This would be similar to the CSS z-index.

from jasper-client.

A priority system would work, but it may be a little tricky to keep track of at times. Another possibility would be to setup an ORDER attribute that would work on keys like after:module1 or before:module3.

from jasper-client.

Alternatively you could move the list to a settings file. That way it is not hard coded into the application but rather configurable via settings.
It's not as beautiful as dynamically loading them from a dir, but in my opinion you should not have to edit the source code for stuff like that

from jasper-client.

Finally got around to this! See 0a377be

from jasper-client.