[Discussion] Clean Architecture - is it really? about northwindtraders HOT 4 CLOSED

Hi!

I think that although there is no direct dependency, the dependency on the Data Persistence framework (EF) has "leaked" into the Application layer. If (at some stage of development) it becomes necessary to change the implementation of the repositories to use NHibernate, Dapper, or pure ADO.Net, then we will face many problems. At a minimum, the current interface assumes that the repository implementation can translate Expressions into queries to the Storage, which is not always true. Moreover, the dependency on EF clearly says that you have to use a SQL-oriented database as Storage. The current limitation will not allow me to store data in files, Redis or MongoDB, which I would like to be able to do.

Again, Jason said that it is bad practice to use EF attributes in domain entities - the framework "leaks" to the domain level. So why do we agree that the leaking framework to the Application layer is acceptable?

I believe that in this case, it is worth getting rid of the dependency on EF at the Application level.

from northwindtraders.

Hey @HydraulicCamel
I believe that dependency from the EF Core does not equal dependency from the persistent layer.
The dependency rule works in this case: the application layer can not depend on the data access layer. But it depends (it uses) data access interfaces.
And there is no reference from the Application to Persistence.

But data access interface uses DbSet and depends on EF Core. Is it correct to add EF Core to the application layer?
I believe it is correct because you do not need a repository over DbSet.
The author of the "Entity Framework Core in Action" book suggests adding an EF Core to the Domain layer. I do not think that EF Core in the domain is a good idea. But EF Core in the application works great.
Because you do not use SQL server directly from your code.

What do you think about it?

from northwindtraders.

A lot of valid points have been made in this thread, but I believe Jason has chosen this approach with EF Core for the sake of simplicity. Does this comment provide enough insight?

from northwindtraders.

Thank you for your interest in this project. This repository has been archived and is no longer actively maintained or supported. We appreciate your understanding. Feel free to explore the codebase and adapt it to your own needs if it serves as a useful reference. If you have any further questions or concerns, please refer to the README for more information.

from northwindtraders.