Git Product home page Git Product logo

Comments (4)

jasonacox avatar jasonacox commented on July 20, 2024

Hi @wcwong, yes, please submit a PR. Your 2nd point was on my to-do list and the 1st one is a great addition. Thanks for the suggestion and help!

from pypowerwall.

wcwong avatar wcwong commented on July 20, 2024

ok. will do but please don't wait on me. I'm not sure how much time I'm going to have until the weekend and I still need to figure out PRs (the last time I contributed something, it was back in the days of email'ing diffs... :)

from pypowerwall.

jasonacox avatar jasonacox commented on July 20, 2024

Ha! Thanks, @wcwong, but now I really want you to have the opportunity to submit a PR! It's so much easier now. Github will do a lot of the work for you, and honestly, I would love to have your help. :)

If you are willing, give it a try this weekend.

from pypowerwall.

jasonacox avatar jasonacox commented on July 20, 2024

Hi @wcwong Thanks for the PR! Good job.

I noticed that you are not showing up as a contributor. This can happen if the email you used to commit the change is not mentioned in your github profile. You should be able to fix it:

  1. Go to https://github.com/settings/emails
  2. Add your email to 'Add Email address'

The email address you used can be seen here: https://github.com/jasonacox/pypowerwall/commit/2454b5ed24e402659931effe3236555568819037.patch

from pypowerwall.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.