Redefinition of ThreadingHTTPServer in server.py and server-r.py about pypowerwall HOT 4 OPEN

Lines 110-112 appear to redefine ThreadingHTTPServer

That's a class override to inject daemon_threads = True but I'll need to investigate when I get some time. Are you seeing any odd behavior?

Thanks @BuongiornoTexas .

from pypowerwall.

I'm not seeing any odd behaviour.

But isn't line 110 re-declaring rather than over-riding ThreadingHTTPServer? That is, this creates a new class type inheriting from HTTPServer and ThreadingMixIn (i.e. discarding the imported definition and replacing it with the new class). That's certainly the warning I'm getting from mypy.

Your declaration should give the same result as the import - I checked the library module, and the definition of the imported ThreadingHTTPServer is the same as your redeclaration.

class ThreadingHTTPServer(socketserver.ThreadingMixIn, HTTPServer):
    daemon_threads = True

So not an issue now, just an oddity.

from pypowerwall.

I just did what I should of have done in the first place and tested commenting out lines 110-112. From a quick and dirty check, it looks as though the server operates as expected - in particular threads fire up and don't block.

Given I've gone a PR for ToU that includes minor changes to server.py, are you happy for me to roll this into that PR?

from pypowerwall.

Yes, please do!

from pypowerwall.