Proxy cache-control not set correctly about pypowerwall HOT 11 CLOSED

In PR #32 I just submitted I changed PW_PROXY_CACHE to PW_BROWSER_CACHE as I believe that more accurately describes what we are doing her (controlling the browser cache settings, not the proxy's). I edited my original post above to reflect that I implemented with that variable name.

The PR includes update to README.md file, but not RELEASE.md file as I don't know if you plan anything else for next release.

David

from pypowerwall.

Just tested this and it's working great. Thanks!

from pypowerwall.

Yes the update is now available as jasonacox/pypowerwall:latest

Thank you. I just realized that I needed to run the upgrade.sh script. I did that and it now flys. Loading the power flow graphic is so much faster now that it is cached.

from pypowerwall.

I notice that server-r.py is very similar but does not include the (buggy) attempt to set Cache-Control. But this proposed fix should probably be applied to that file as well?

from pypowerwall.

Also having this same problem. It's breaking other applications on the same host until I clear the bad cookie. Looks like this is blamed on 76a2344. I like the solution from @dkerr64.

from pypowerwall.

Brilliant @dkerr64 !! I love it. Do you want to submit the Pull Request? I'm happy to make the changes but prefer to make sure you get credit.

As for server-r.py, that was a prototype that has fallen behind a bit. It was attempt to add a simple auth cookie restriction to help with public access. It's a bit clunky and frankly not very secure. If it worked, the functionality would have been ported to server.py. Long way to say: don't worry about adding the updates to server-r.py. 😉

from pypowerwall.

Thank you, yes I'll do a pull request.

from pypowerwall.

Thanks David! This is great. I updated release to t25 and will test and push to latest on dockerhub soon.

from pypowerwall.

@jasonacox is this on docker hub yet? I need it there to easily update my Powerwall-Dashboard server.

Thanks
David

from pypowerwall.

Yes the update is now available as jasonacox/pypowerwall:latest

from pypowerwall.

Awesome! Thanks for your help and contribution @dkerr64 !!

from pypowerwall.