Comments (22)
Alright, I emailed @jashkenas for assistance. It will probably take at least a couple of days until he finds time to sort these things for us.
from backbone.
Actions still didn't start, may be it should be kinda "approved" for a first time?
from backbone.
Very interesting, my other workflow is started ok. I will dig it later, something wrong with my initial proposal.
from backbone.
We have three options.
Travis CI is not running because we have to migrate the repository from travis-ci.org (which stopped operating) to travis-ci.com (which should still be free for open source). I could contact @jashkenas about that, and then Travis CI would probably start working again. I already started that process for Underscore.
While I personally don't like GitHub Actions, I recognize that it would remove a dependency on an external service. If you can help me get everything to work, not just now but in the future as well (I'll eventually want to enable automatic deployment), then I welcome a pull request that replaces Travis CI by GitHub Actions.
The third option would be to mirror the repo to GitLab and use their pipelines instead. They explicitly support such usage, and I like their more straightforward, traditional DSL.
from backbone.
I can support gh actions, no prob, they very similar to gitlab ci, with more flex syntax (imho)
You want to integrate semantic release?
from backbone.
Eventually. For now though, let's just replace the functionality that Travis provided.
Great that you want to support this, by the way, much appreciated.
from backbone.
Sure, will look at it on weekend
from backbone.
@jgonggrijp can you please enable Actions in Settings -> Actions?
from backbone.
Unfortunately, no, I don't have access to the settings. I suspect Actions are enabled by default, though (at least they are on my fork of the repo), and that they're only not kicking of in your PR because the config needs to be on the default branch first.
I could just merge your PR and hope for the best. However, I noticed that you're also depending on secrets.SauceUsername
and secrets.SauceAccessKey
for the karma tests. I'll have to ask @jashkenas to configure those. Unless you can copy those from the old .travis.yml
and hardcode them in the same way in the new .github/workflows/tests.yml
. I understand that's not a best practice, but they were already public, so at least it doesn't make matters worse.
from backbone.
@ogonkov I'm pretty sure Actions is already enabled, because the tab is already in the navigation bar and I can start adding a workflow based on a template with the click on a button.
from backbone.
I guess Actions tab could be just a kind of promo, that always visible.
Travis has encoded secrets, i can't just copy it to Workflows, i'm afraid.
In my other repo Workflows just works from initial PR, without need to be merged in master, so i guess there should be some additional setup, to get it work.
from backbone.
Jeremy replied to my email. He wrote that he will try to get to it soon.
from backbone.
Any news?
from backbone.
Jeremy made an attempt yesterday, but he got stuck because one piece of information in my email was incomplete and another was outdated. I provided the missing information and he'll be making another attempt. He did confirm that GH Actions was already enabled.
from backbone.
Update: Jeremy tried again and succeeded. However, he had no Sauce Labs credentials ready to fill the secrets with, so he left those empty. Fortunately, I should theoretically be able to set those myself using the GitHub API. I'll create my own Sauce Labs account shortly after posting this and then attempt to set those secrets using the API.
from backbone.
The registration process for "Open Sauce" (which does what the name suggests) starts with an application form, which apparently will be reviewed by a real human. I should get a response within 48 hours.
from backbone.
What I'm seeing is different from what is in that documentation page:
Don't worry though, I'm sure it will run once it's merged into master
.
from backbone.
I think we could try to merge it then
from backbone.
I will, but I prefer setting up those secrets first. I still need to receive my account credentials from Sauce Labs.
from backbone.
@ogonkov I entered the secrets and merged your branch, but the workflow is still not kicking off. GitHub does recognize the workflow but somehow seems to think it doesn't need to run; see https://github.com/jashkenas/backbone/actions/workflows/tests.yml. Could the problem be in the branches: ${{ github.event.repository.default_branch }}
lines?
from backbone.
It should not be a problem. I can try to change it to master
, but i guess the problem is somewhere else.
from backbone.
Something weird with variables, they don't seem to interpolate properly. I didn't get the reason why it happen. Otherwise pipelines now works and tests are running (except Sause labs that use secrets and env variables)
from backbone.
Related Issues (20)
- Backbonejs (1.4) version compact with jQuery (3.4.1) ? HOT 2
- Token error 'delete' on an old browser HOT 3
- How can I use installed npm library in backbone view
- Backbone is being actively maintained HOT 29
- Embrace prototypes HOT 12
- Upgrade devDependencies, add lockfile HOT 21
- Should Backbone.Collection throw an error when client code attempts to add the same model twice? HOT 8
- Browser tests that don't work in Sauce labs
- Separate fetch/save api into plugin or external module HOT 17
- Bug in _removeModels: function(models, options) { HOT 1
- Uots about time
- error event not firing for Collection.create with wait true HOT 4
- Clean up misguided legacy changes HOT 1
- Community question: who is interested in reviewing my pull requests? HOT 3
- Testing against outdated vendor libraries HOT 1
- Misleading line in CONTRIBUTING.md HOT 2
- ES Modules: please discuss HOT 33
- Changelog? HOT 1
- Will updating backbone also update jquery? [answered: no] HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone.