Git Product home page Git Product logo

Comments (22)

maxice8 avatar maxice8 commented on May 15, 2024 2

nlay now uses #!/usr/bin/env bash which should work on OpenBSD without modification.

from nnn.

jarun avatar jarun commented on May 15, 2024 1

All-snprintf() committed at 460984c.

from nnn.

jarun avatar jarun commented on May 15, 2024

Thanks!

from nnn.

jarun avatar jarun commented on May 15, 2024

While you are at it (and if you can kindly spare the time), could you please consider porting the following of my utilities to OpenBSD -

All of them are officially available on Ubuntu, Debian and under review on Fedora.

from nnn.

jolpaz avatar jolpaz commented on May 15, 2024

Sorry for the delay. OpenBSD port of nnn is created and submitted for testing and review (http://bit.ly/2IbcvnG). There were no mac-study jor issues, needed to patch two files though:

Index: Makefile
--- Makefile.orig
+++ Makefile
@@ -1,7 +1,7 @@
 VERSION = 1.7
 
 PREFIX ?= /usr/local
-MANPREFIX ?= $(PREFIX)/share/man
+MANPREFIX ?= $(PREFIX)/man
 STRIP ?= strip
 PKG_CONFIG ?= pkg-config
 
@@ -32,15 +32,16 @@ debug: $(SRC)
        $(CC) -DDEBUGMODE -g $(CFLAGS) $(LDFLAGS) -o $(BIN) $^ $(LDLIBS)
 
 install: all
-       install -m 0755 -d $(DESTDIR)$(PREFIX)/bin
-       install -m 0755 -t $(DESTDIR)$(PREFIX)/bin $(BIN) $(PLAYER)
-       install -m 0755 -d $(DESTDIR)$(MANPREFIX)/man1
-       install -m 0644 -t $(DESTDIR)$(MANPREFIX)/man1 $(BIN).1
+       install -m 0755 -d $(PREFIX)/bin
+       install -m 0755 -d $(MANPREFIX)/man1
+       install -m 0755 $(BIN) $(PREFIX)/bin/
+       install -m 0755 $(PLAYER) $(PREFIX)/bin/
+       install -m 0644 $(BIN).1 $(MANPREFIX)/man1/
 
 uninstall:
-       $(RM) $(DESTDIR)$(PREFIX)/bin/$(BIN)
-       $(RM) $(DESTDIR)$(PREFIX)/bin/$(PLAYER)
-       $(RM) $(DESTDIR)$(MANPREFIX)/man1/$(BIN).1
+       $(RM) $(PREFIX)/bin/$(BIN)
+       $(RM) $(PREFIX)/bin/$(PLAYER)
+       $(RM) $(MANPREFIX)/man1/$(BIN).1
 
 strip: $(BIN)
        $(STRIP) $^

and

Index: nlay
--- nlay.orig
+++ nlay
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/local/bin/bash
 
 # #############################################################################
 # nlay: a customizable script to play files in different apps by file type

Also there was a warning regarding usage of sprintf() as opposed snprintf() later being considered safer.

As for the porting of above listed utilities, I'll take a look at them and let you know.

from nnn.

jarun avatar jarun commented on May 15, 2024

needed to patch two files though

Should be fine as long as they are patched downstream

Also there was a warning regarding usage of sprintf()

I can work on this and use snprintf() everywhere

I'll take a look at them and let you know

Thank you so much!

from nnn.

jarun avatar jarun commented on May 15, 2024

@jolpaz any update on this? Did you find some time to check the other utilities as well?

from nnn.

jolpaz avatar jolpaz commented on May 15, 2024

from nnn.

jarun avatar jarun commented on May 15, 2024

I'll let you know as soon as it makes into repositories

Thanks for the update

Other utils are also on my todo list for review so I'll keep you posted.

Sure! Just wanted to ensure you have checked them out.

consider releasing source code tarballs the same way linux/freebsd tarballs are released

How do I do that? I am only using github default. Is there a way to change it?

from nnn.

fennm avatar fennm commented on May 15, 2024

@jolpaz You can have github autogenerate the tar in the format you're looking for (for any git ref) by constructing a URL like this: https://github.com/jarun/nnn/archive/v1.7/nnn-1.7.tar.gz

from nnn.

jolpaz avatar jolpaz commented on May 15, 2024

from nnn.

jarun avatar jarun commented on May 15, 2024

is what I was looking for

OK. Then you have found what you wanted. I didn't know this one! ;) Thanks @fennm!

How do you guys usually release debian, centos, suse and other packages?

We use PackageCore to auto-generate them on Travis CI.

from nnn.

fennm avatar fennm commented on May 15, 2024

from nnn.

jarun avatar jarun commented on May 15, 2024

@jolpaz please update when the porting is done and we will add openBSD to the list of packagers.

from nnn.

jolpaz avatar jolpaz commented on May 15, 2024

I'm happy to announce that nnn made it to OpenBSD ports repository -- http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/sysutils/nnn/. As of few hours ago it is available for anyone to build it using OpenBSD's ports system. I will announce availability of binary package as soon it hits the mirrors.

Thank you for the great tool and support during porting effort.

from nnn.

jarun avatar jarun commented on May 15, 2024

Thanks @jolpaz!

from nnn.

jarun avatar jarun commented on May 15, 2024

Please let us know the command to install. pkg_add nnn maybe?

from nnn.

jolpaz avatar jolpaz commented on May 15, 2024

@jarun, that would be the correct command, but not yet. Port made it to OpenBSD's ports CVS repository and is not yet available as a binary package. It will become available as a binary package with the next round of bulk builds -- I'll let you know. When that happens, OpenBSD -current users will be able to install it with the above command. As for the -stable and -release OpenBSD users nnn will not be available for them as a binary package till the next release, some time in October. There are ways of installing -current binary package on -stable or -release systems -- I'll let you know that as well when first binary is available.

In the meantime any OpenBSD user can install nnn using ports.

from nnn.

jarun avatar jarun commented on May 15, 2024

Thanks! Once you update I will add it to the list of packagers.

from nnn.

ljuba-ned avatar ljuba-ned commented on May 15, 2024

I'm happy to announce the availability of nnn binary package for OpenBSD-current users. Such users with up to date systems can install it with pkg_add nnn as root.

For users of -stable and -release OpenBSD systems, nnn can be installed with:

pkg_add https://ftp2.eu.openbsd.org/pub/OpenBSD/snapshots/packages/amd64/nnn-1.8.tgz

again, as root.

Please note that ftp2.eu.openbsd.org can be replaced with any mirror listed at mirrors list

Happy hacking!

from nnn.

maxice8 avatar maxice8 commented on May 15, 2024

from nnn.

jarun avatar jarun commented on May 15, 2024

Thanks @jolpaz!

from nnn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.