transducers on write-ch receive formatted value about chord HOT 5 OPEN

Hey Alex, thanks for getting in touch :)

Yep, I agree - would certainly be useful to be able to apply a transducer before formatting, although I'd like to try avoid a breaking change if possible - you can bet that it will break someone's workflow!

Thinking out loud:

• I wonder whether we could introduce an additional pre-freeze/post-thaw channel?
• Maybe we could allow the user to supply transducers?
• Is it Chord's responsibility at all? what would a user have to do if Chord didn't support it? (maybe the answer to this will influence what the Chord API change should be?)

What do you think?

Cheers,

James

from chord.

from chord.

Cheers - all good suggestions.

On balance I prefer the new :read-chan/:write-chan option - it gives the user the option to create the channel however they'd like (they may even have one in hand already) and also insulates us against future changes to how people might be able to create core.async channels. Would it be something you'd have time to create a PR for?

James

from chord.

Yep, I can make a PR.

So to summarise: I’ll add :read-chan and :write-chan options. These will be mutually exclusive with :read-ch and :write-ch - chord will throw if they’re used together.

The existing behaviour will be preserved when the existing options are used.

I’ll update the docs deprecating the existing options and describing the behaviour of the new ones.

from chord.

Great, cheers 😄

from chord.