Git Product home page Git Product logo

Comments (10)

jaredonline avatar jaredonline commented on June 10, 2024

Hey @fabiokr: I'd love to, but I don't have the time right now to figure it out. Can you make a stab at a pull request?

from google-authenticator.

sporkmonger avatar sporkmonger commented on June 10, 2024

Is there actually any known incompatibilities w/ Rails 4?

from google-authenticator.

jaredonline avatar jaredonline commented on June 10, 2024

Sorry, was out of town for the weekend.

I'm not aware of the specific issues, but when we tried to allow any Rails greater than 3 it broke the current specs, see #8

Can you try it with Rails 4 and see what happens?

from google-authenticator.

sporkmonger avatar sporkmonger commented on June 10, 2024

I haven't tried running the specs, but I'm running the gem against Rails 4 just fine without any obvious issues. I'm not using the session stuff though.

from google-authenticator.

jaredonline avatar jaredonline commented on June 10, 2024

Would you mind trying the specs?

from google-authenticator.

jaredonline avatar jaredonline commented on June 10, 2024

@sporkmonger Any luck?

from google-authenticator.

sporkmonger avatar sporkmonger commented on June 10, 2024

Sorry, got tied up w/ some other stuff. We just ran into some bugs w/ this part of our codebase though, so I'll try to take care of it at the same time.

from google-authenticator.

jaredonline avatar jaredonline commented on June 10, 2024

@sporkmonger No worries. Let me know if there's anything I can help with. Very grateful that you're taking the time to look into it.

from google-authenticator.

reginato avatar reginato commented on June 10, 2024

hey guys.
Is it ready for rails 4?

from google-authenticator.

jaredonline avatar jaredonline commented on June 10, 2024

@reginato @sporkmonger @fabiokr 1.0 is out

from google-authenticator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.