`FormAtomValues` hints wrong type to the developer about form-atoms HOT 5 CLOSED

Am I missing something? Wouldn't this work nearly as well while remaining readable? I get that it doesn't display to the developer perfectly, but it is a slight improvement that type checks correctly which is the important thing.

export type FormFieldValues<Fields extends FormFields> = {
  [Key in keyof Fields]: Fields[Key] extends FieldAtom<infer Value>
    ? Value
    : Fields[Key] extends FormFields
    ? FormFieldValues<Fields[Key]>
    : Fields[Key] extends Array<infer Item>
    ? Item extends FieldAtom<infer Value>
      ? Value[]
      : Item extends FormFields
      ? FormFieldValues<Item>[]
      : never
    : never;
};

from form-atoms.

@jaredLunde Yes, the version from case 1 will be ok, as it is an improvement.

I don't like the readability of the _FormAtomValues from case 2 neither, it was only illustration that its possible to achieve :)

Maybe typescript will improve this automatically in the future, by eagerly resolving the 'generit type calls' instead of displaying them. Who knows.

from form-atoms.

I prefer the current type as it is more readable and thus easier to maintain.

from form-atoms.

🎉 This issue has been resolved in version 2.0.0-next.1 🎉

The release is available on:

• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from form-atoms.

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from form-atoms.