Common type for something that can be rendered about scalajs-react HOT 7 CLOSED

Yeah I believe that's already possible. I think the type you're looking for is VDom. Does that work for you?

from scalajs-react.

You are right, I can pass both a Component() and a div(Component()) as a VDom.

Unfortunately I can't pass the resulting VDom to another tag, such as div(myVDom). I get the following error:

[error] found : japgolly.scalajs.react.VDom
[error] required: japgolly.scalajs.react.vdom.ReactVDom.Modifier

from scalajs-react.

Maybe I misunderstood (or even gave you wrong info re VDom), is this the kind of thing you're trying to do?

https://github.com/japgolly/scalajs-react/blob/master/example/src/main/scala/japgolly/scalajs/react/example/ReactExamples.scala#L83-L85

https://github.com/japgolly/scalajs-react/blob/master/test/src/test/scala/japgolly/scalajs/react/CoreTest.scala#L112-L127

If not, are you able to show me a bit of the code?

from scalajs-react.

I can put components inside div/span/etc without problems if it's directly. I can't put elements of type "VDom" inside div/span/etc.

I've created a toy example to show the issue. Let's create a component that gets something that can be rendered and renders it twice.

  object Duplicate {
    def apply(element: VDom) = ReactComponentB[Unit]("Duplicate")
      .render { props =>
        div(element, element)
      }
      .create(())
  }

This produces the same compile error as before:

[error]  found   : japgolly.scalajs.react.VDom
[error]  required: japgolly.scalajs.react.vdom.ReactVDom.Modifier
[error]     (which expands to)  scalatags.generic.Modifier[japgolly.scalajs.react.vdom.VDomBuilder]
[error]         div(element, element)

from scalajs-react.

Ah sorry Artur, I gave you the wrong information - I'm always forgetting the Scalatags types and the way I integrated a bit of that. You want Modifier. I'll make a note to simplify these types soon.

  object Duplicate {
    def apply(element: Modifier) = ReactComponentB[Unit]("Duplicate")
      .render { props =>
      div(element, element)
    }.create(())

    apply(h1("hello"))

    val HelloMessage = ReactComponentB[String]("HelloMessage")
      .render(name => div("Hello ", name))
      .build.apply("hehe")

    apply(HelloMessage)
  }

from scalajs-react.

Works great, thanks!!!

from scalajs-react.

Great to hear. Enjoy!

from scalajs-react.