Comments (5)
from backbone-couchdb.
:-)
Not sure if thats the whole fix, looking at the other error handlers this might be required:
diff --git a/js/vendor/backbone-couchdb-1.2.js b/js/vendor/backbone-couchdb-1.2.
index 5c23a4d..be89ebe 100644
--- a/js/vendor/backbone-couchdb-1.2.js
+++ b/js/vendor/backbone-couchdb-1.2.js
@@ -168,9 +168,9 @@ backbone-couchdb.js is licensed under the MIT license.
success: function() {
return opts.success();
},
- error: function(nr, req, e) {
+ error: function(status, error, reason) {
var res;
- if (e === "deleted") {
+ if (error === "deleted") {
opts.success();
return opts.complete();
} else {
from backbone-couchdb.
:-) May I redirect your attention to the line that also renames status and reason? As those are also used in the error handler - but I have no idea if the order of the arguments differs in this error handler to all other error handlers.
from backbone-couchdb.
Didn't see that ^^
Should be fixed now, what do you say?
On Nov 2, 2012, at 10:48 AM, Martin HΓ€cker [email protected] wrote:
:-) May I redirect your attention to the line that also renames status and reason? As those are also used in the error handler - but I have no idea if the order of the arguments differs in this error handler to all other error handlers.
β
Reply to this email directly or view it on GitHub.
from backbone-couchdb.
looks good.
from backbone-couchdb.
Related Issues (20)
- bycollection view should probably return doc_.id instead of doc HOT 5
- Support for deletion changes? HOT 3
- Possibility to pass include_docs when reading from views HOT 4
- Unpatched Backbone.Model still remians in Backbone.Collection::model HOT 2
- Objects returned by Model.clone() contain _id and _rev attributes of the cloned object HOT 1
- fetch method on collection not returning deferred object HOT 6
- just bumped into bb-cdb again today HOT 2
- Add the option to use lists and shows HOT 2
- jquery.couch.js in README defunct HOT 1
- Question about views and filters HOT 1
- Support CouchDB _updates HOT 3
- Compatibility with backbone-relational.js HOT 1
- Register Bower Package HOT 1
- I don't think doc.doc is what is needed during a fetch
- Add support for backbone 0.9.9 HOT 1
- Accept doc.key instead of doc.value for group-by/distinct mapreduce views
- Fetch does not return XHR
- Need a way to get a single model by a non-ID attrib
- License file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from backbone-couchdb.