Comments (6)
What is your operating system, python version (e.g., run python --version
) and prompt_toolkit version (e.g., run python -c "import prompt_toolkit; print(prompt_toolkit.__version__)"
)?
from hdtv.
Hi, I have exactly the same issue described above. I am running on Ubuntu 22.04.3 LTS, with ROOT 6.28.10 (but I also tried previous releases). My python version is 3.10.12 and prompt_toolkit version is 3.0.43. Could you help me please?
from hdtv.
I could reproduce the issue - in SimpleUI print
, the event loop is not running when call_soon_threadsafe
is called (or at least something like that).
hdtv.cmdline.command_line.loop.call_soon_threadsafe(
self.print_patched, HTML(html), end
)
Im not sure what the loop is for - I see only few usages. The commented out self.print_patched(HTML(html), end)
seems to work.
@op3, do you remember the specifics of Add support for prompt_toolkit 3.0 (asyncio)?
from hdtv.
Thanks! Indeed commenting out that line, everything seems to work.
from hdtv.
I have not managed to reproduce this exact issue yet. However, I can trigger the same behavior by entering and exiting a python shell in hdtv (execute python
inside hdtv and then exit()
it again) (thanks to @j-kleemann for noticing this).
I think I had similar problems (no output) when I ported the code to prompt_toolkit 3.0 in e4d18ca before introducing call_soon_threadsafe
, but I donβt remember the specifics.
Edit: I can reproduce the problem using our docker image
from hdtv.
The problem should be fixed now. Printing also works after entering and leaving an ipython shell inside hdtv.
When closing hdtv using the close button of the graphical window, we have to make sure that the event loop is stopped before ROOT exits. For this, we need an event loop that can be addressed. Because the behavior of prompt_toolkit changed, this event loop was never started. We now manually create a dedicated thread to run the event loop. Printing works, and exiting hdtv both from the terminal and the GUI works (without segfaulting).
from hdtv.
Related Issues (10)
- no interpreter information for class HDTV::Fit is available HOT 1
- Performance degradation with ROOT 20.04 & 22.6 HOT 3
- Prepare Release 20.10 HOT 3
- Crash on startup when reading malformed history file HOT 1
- Using hdtv for coincidence analysis HOT 4
- Issue when running the docker container HOT 2
- problem with source compiled root HOT 13
- .spk file format is not readable HOT 1
- prompt toolkit changes break hdtv HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hdtv.