Comments (3)
MareoRaft
commented on June 2, 2024
Splitting this file up is a good idea, but I don't think it needs to be done for 2.0.0, since it makes no difference to the user.
from js-set-extension.
jankapunkt
commented on June 2, 2024
Yes we can keep this open for later. For now we should be still good to go.
from js-set-extension.
MareoRaft
commented on June 2, 2024
Here would be my suggestion for breaking down index.js into separate files:
utils.js
Helper functions / variables that never get attached to Set or Set.prototype:
- suggest
- checkRules
- checkSet
- checkSets
- checkArgsSingle
- arbitraryToBinary
- correctSetNameToIncorrectNames
- correctSetPrototypeNameToIncorrectNames
- setSuggestions
The remaining code could be broken down into an arbitrary.js file where you define the overrides on Set and then a binary.js file where you define the overrides on Set.prototype.
from js-set-extension.
Related Issues (20)
- differences HOT 2
- products HOT 2
- power set HOT 1
- Keep orinal constructor name and add a flag instead to indicate the polyfill is present HOT 1
- more meta tags so people can find repo HOT 3
- Version 2 HOT 8
- Suggested properties HOT 5
- suggested function list HOT 7
- isEmpty method HOT 4
- create randomElement method HOT 3
- better whitespace in docs HOT 10
- Code coverage broken? HOT 1
- suggested Set implementation for JS 5 HOT 4
- Why can we use global variable? HOT 3
- Update CI Environment HOT 3
- Power sets are broken for ES6 HOT 5
- Replace global with globalThis for browser HOT 3
- Union HOT 3
- intersections HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-set-extension.