Git Product home page Git Product logo

Comments (7)

sophiekovalevsky avatar sophiekovalevsky commented on August 21, 2024

I forgot to mention that I would be happy to incorporate this feature by myself.

from librevna.

jankae avatar jankae commented on August 21, 2024

This could certainly be useful. Maybe add the option for a different color instead of opacity? I could imagine that opacity does not work well for certain background colors (e.g. white).

from librevna.

sophiekovalevsky avatar sophiekovalevsky commented on August 21, 2024

@jankae i ran several tests and I guess that if we don't set opacity would be more difficult for user to select the right color so it can combined at same time with actual background. On the other side, if I set the opacity with a different color, what I will get won't be exactly the color I think would be, that's the downside.

I set plotAreaTop variable because I will work this week on the other implementation and for that I think we need to set an offset on plot so traces background don't overlap with the actual start of plot.

from librevna.

sophiekovalevsky avatar sophiekovalevsky commented on August 21, 2024

@jankae just found out a bug in my implementation, I will fix it soon and let you know when you are actually review it. Thanks.

from librevna.

sophiekovalevsky avatar sophiekovalevsky commented on August 21, 2024

I think I fixed the issue. I revert the opacity feature since when viewing trace in auto-mode it seems like ticks width are not evenly spaced which completely disappears if opacity is disabled.

from librevna.

jankae avatar jankae commented on August 21, 2024

I still had some issues on my system with the X axis ticks not being visible everywhere, because the second background color was drawing over them, but that was a simple fix by just moving around some lines of code, looks good to me now. I also changed the default value to better match the default of black for the "normal" background, I hope you don't mind

from librevna.

sophiekovalevsky avatar sophiekovalevsky commented on August 21, 2024

I didn't noticed this and thanks for fixed.

from librevna.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.