Git Product home page Git Product logo

Comments (4)

bakpakin avatar bakpakin commented on July 2, 2024 2

Using flycheck is much too heavy-handed here. We could just adapt the peg to either fail if it doesn't make it to the end of the string, or capture and emit the rest of the input verbatim from where the match failed.

from spork.

sogaiu avatar sogaiu commented on July 2, 2024

FWIW, it looks like it's not necessarily just the last line:

$ janet -l spork/fmt
Janet 1.13.2-dev-local linux/x64 - '(doc)' for help
repl:1:> (def c "(def a 1)\n(def b 2)\ndef c (+ a b))\n(print c)\n(print c)")
"(def a 1)\n(def b 2)\ndef c (+ a b))\n(print c)\n(print c)"
repl:2:> (format-print c)
(def a 1)
(def b 2)
def c (+ a b)
nil
repl:3:>

Is it possible to use the new flycheck function from boot.janet usefully in this context before trying to format?

On a side note, for judge-gen, I've been thinking about whether to run code through a linter (e.g. janet -k) before trying to process incoming source code. Processing broken code can produce strange results.

from spork.

pepe avatar pepe commented on July 2, 2024

I want to take a stab at this, but I would like to ask about the best way you see here @bakpakin. I still have a problem grasping your PEGs, yet I still have the desire to get to this level of thought. And every help with it is appreciated.

from spork.

pepe avatar pepe commented on July 2, 2024

In #21, I propose a fix with the first solution: fail when peg does not make it to the end.

from spork.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.