undefined method Reference::getType() about janephp HOT 7 CLOSED

Hi :) Could you provide the OpenAPI schema that is doing this error ?

from janephp.

Hi,

Sorry for the delay, I was on holiday.

The OpenApi schema can be found at this url : https://demo.tagpay.fr/doc/public/distributor.yml

from janephp.

So, I did some research about your bug.

First, I can reproduce it in local 🎉 But that's where the problems begin ...
Your bug is caused by OpenApi Schema normalization (here https://github.com/janephp/janephp/blob/master/src/OpenApi/JaneOpenApi.php#L58).
It seems he can't understand reference that are themself a variable (in your case it's an object called UserProfileId which cause all that trouble cause it's a string (and should be not regognize as an object).

I'll pause my search here for now, but that's a nice bug we got here 😄

from janephp.

Thanks for your investigation !
Indeed references will not always point to an object type.
We use references pointing to "base types" to factorize descriptions or constraints.
In this case, we consider "IDs" as meaningful types because it can be used in multiple endpoints, and are not just "data" : they are pointing to an identified resource.

Please tell me if you need any help fixing the bug.

from janephp.

So I tried with simple tests with reference of simple type in both model and response and both are working ok. I think there is a bit more about your case.

from janephp.

And here is the minimal reproducer:

{
    "openapi": "3.0.0",
    "info": {
        "version": "",
        "title": ""
    },
    "paths": {
        "/foo": {
            "get": {
                "operationId": "foo",
                "parameters": [
                    {
                        "name": "bar",
                        "in": "query",
                        "schema": {
                            "$ref": "#/components/schemas/Bar"
                        },
                        "required": true
                    }
                ],
                "responses": {
                    "default": {
                        "description": "Default response"
                    }
                }
            }
        }
    },
    "components": {
        "schemas": {
            "Bar": {
                "type": "string"
            }
        }
    }
}

Reference as type is correctly handled everywhere except in endpoint parameters.

from janephp.

It seems like the solution in #126 handles $ref directly inside "schema" declarations under "parameters", but will crash with multiple jumps in references:

openapi: 3.0.3
info:
  title: issue-108-edge-case
  description: irrelevant
  version: v1
paths:
  /an-endpoint:
    get:
      operationId: an-id
      parameters:
      - $ref: "#/components/parameters/Offset"
      responses:
        200:
          description: a response
          content:
            application/json:
              schema:
                type: object
components:
  parameters:
    Offset:
      name: offset
      in: query
      schema:
        $ref: "#/components/schemas/Offset"
      description: The number of items to skip.
      required: false
      example: 20
  schemas:
    Offset:
      type: integer
      format: int32
      description: The number of items to skip.
      minimum: 0
      default: 0

EDIT: forking and creating a ticket. The problem is easily highlighted by the type-checker.
EDIT 2: yo, really need to start dropping PHP < 8.1, y'all :|

from janephp.