Comments (4)
Somewhat related: it might be worth adding a note somewhere on the requirements for running the tests locally. As well as the standard of needing pytest
, when trying to run the tests I got an error that fixture 'qtbot' not found
, which I tracked to being because pytest-qt
is also required to run the tests. This isn't clearly noted anywhere.
Somewhere, I would add a note of test-requirements, and maybe some instructions on running tests locally (this is perhaps most relevant in a contributor guide, as you would likely want contributors to run and check tests.
As a note, I was able to run tests locally. I'm not sure of the coverage (adding that is a good idea), though the GUI tests looked (in terms of how many things popped up) fairly comprehensive.
from biopeaks.
it might be worth adding a note somewhere on the requirements for running the tests locally
@TomDonoghue, I've included testing instructions in the contributor guide (see 6685c6e).
from biopeaks.
It would be great to add a tool that measures what proportion of your code is actually covered by the tests.
@sappelhoff, I now collect and report code coverage. However, the coverage is deceptively low (59%) since pytest-cov does not seem to pick up on code that is run within threads (see here). Looking into it.
from biopeaks.
Closing and transfering to #21, since original issue has been addressed.
from biopeaks.
Related Issues (20)
- Suggestion: Add docs on how docs are being built HOT 3
- Discussion: Adopting a consistent style for docstrings HOT 4
- Make use of a dedicated example file in "getting-started" section in docs HOT 2
- Question/suggestions about benchmark files HOT 3
- custom zoom gets undone during manual peak editing + other issues
- Small suggested paper edits HOT 1
- Recommended Code CleanUps
- GUI Questions HOT 5
- Idea: Adding pictures to the User Guide Walk-Throughs
- Suggestion: Add more detailed list of features to the documentation site
- Figure out how to trace threaded code execution with pytest-cov HOT 1
- Port to PySide6 HOT 2
- Questions about the default method of ecg_peaks() in neurokit2 HOT 1
- Add CITATION.cff HOT 1
- Research if plotting can be done with PySide6.QCharts instead of Matplotlib.
- Evaluate NeuroKit suggestion for improving ECG peak detection
- Adding .zenodo.json? HOT 1
- Suggestion: Add classifiers, long_description, and more links to setup.py HOT 1
- Making community and contributing guidelines more visible HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from biopeaks.