results.size is not a function about ghosthunter HOT 11 CLOSED

Ah. $().size() is deprecated. Looks like we can just use $().length there.

from ghosthunter.

... I did a typo when committing 7e0f675
I did a hotfix just now but I won't be able to test until this weekend. If you've got free time, try the latest commit, otherwise revert to 0.4.0 until I finish ironing this out.

Sorry about this

from ghosthunter.

from ghosthunter.

I've tried not setting up the option and leaving the default value, as in the code in my previous comment. And also, tried to set the result_template option like this:

result_template : '<a id="gh-{{ref}}" class="gh-search-item" href="{{link}}"><div class="result-title">{{title}}</div><div class="result-date">{{prettyPubDate}}</div></a>'

from ghosthunter.

Also, forgot to mention that I am using jQuery 3.3.1.

from ghosthunter.

Changing $().size() to $().length fixed this. Thank you, @fbennett !

from ghosthunter.

Should we update that directly in the source repo then ? if we start requiring specific versions of jQuery things are going to get interesting.

from ghosthunter.

After checking the docs it's been deprecated since 1.8... changed, issue closed.

from ghosthunter.

Even with commit 7e0f675 results are broken on my side:

TypeError: results.length is not a function (jquery.ghosthunter.js:3478:15)

My environment:

• Ghost 1.21.3
• jQuery v3.3.1

My index.js:

/* Search with ghostHunter */
$("#search-field").ghostHunter({
    results		: "#search-results",
    includepages 	: true,
    onKeyUp 		: true,
    onPageLoad		: true,
    info_template	: "<p>{{amount}} article(s) trouvé(s)</p>",
    result_template	: "<a id='gh-{{ref}}' class='gh-search-item' href='{{link}}'><p>{{title}}</p></a>"
});

My page-search.hbs:

<section class="article {{post_class}}">
    <form class="search-box">
        <i class="fa fa-search search-icon" aria-hidden="true"></i>
        <input type="search" autocomplete="off" autofocus="on" id="search-field" placeholder="..." />
    </form>
    <div id="search-results"></div>
</section>

from ghosthunter.

@Windyo At least with 7a058da it displays results, that's all I need for now, thank you for that quick fix. ;)

from ghosthunter.

Considering this closed seeing as I use that version also and I haven't seen any issues

from ghosthunter.