.btn compliation issue about corpus HOT 3 OPEN

Could you give me a bit more detail on the issue you here? Just want to make sure I understand the problem and how best to fix it.

from corpus.

First, you should know that the tool you’re building is very nice. Good job!

Because your lib is so new, I don’t want to make changes to your code, and so I add my own files to a global .scss file and import all your files.

The issue I found resulted when I wanted to use a custom background color for a button. By default, I could not change the color. I looked into the compiled .css file, and there were two definitions. One came from the form.scss file, and the other came from the button.scss as it ‘extends’ button. The button class defines a color and background (not something it should really do).

best,
rickg

On Oct 11, 2015, at 6:09 PM, Jamie Wilson [email protected] wrote:

Could you give me a bit more detail on the issue you here? Just want to make sure I understand the problem and how best to fix it.

—
Reply to this email directly or view it on GitHub #7 (comment).

from corpus.

Cool. Thanks for the nice words! And for the clarification. So the way I've been using the library, I haven't run into any problems with button colors. If I have all my corpus modules imported, like so, with a _custom.scss imported last:

@import "corpus/reset";
@import "corpus/breakpoints";
@import "corpus/animation";
@import "corpus/utilities";
@import "corpus/whitespace";
@import "corpus/grid";
@import "corpus/sidebar";
@import "corpus/sizing";
@import "corpus/colors";
@import "corpus/positioning";
@import "corpus/depth";
@import "corpus/typography";
@import "corpus/tables";
@import "corpus/images";
@import "corpus/borders";
@import "corpus/forms";
@import "corpus/buttons";
@import "corpus/syntax";

@import "corpus/custom";

Then in a my _custom.scss file, if I define something like

.btn-danger {
  background-color: red;
}

and add that to my element it works fine. Or even doing

button {
  background-color: grey;
}

works okay too. But if I were wanted to redefine the color of default <button> or .btn elements I would instead redefine the $accent color variable. I give buttons a default color of $accent because i almost always want primary buttons to be the brand accent color.

Does that make sense. Not disagreeing with your feedback, just wanted to explain my rationale.

from corpus.