Git Product home page Git Product logo

Comments (4)

koertho avatar koertho commented on July 29, 2024

I've integrated this feature in my fork (just for jpeg). Can do a pull request, if you want (I never did this before).

from thumb.

jamiebicknell avatar jamiebicknell commented on July 29, 2024

I've never been keen on having a query string option that only applies one particular file format, but I do agree that the quality should be able to be customised somewhere. Instead I think it's best if the quality was configured as a constant and same for each instance.

View commit here: 0930eea

from thumb.

koertho avatar koertho commented on July 29, 2024

That's perfect. Thank you!

from thumb.

jamiebicknell avatar jamiebicknell commented on July 29, 2024

The constant is my preference as I feel the quality wouldn't change on a per image basis, but more or a per install/instance basis. If you do use you're query string version, don't forgot to also add the quality option to the $file_hash variable.

from thumb.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.