Header Mapping doesn't work as expected. about functionmonkey HOT 3 CLOSED

Hi James, Hi Danil. I did a little research on this issue.
TR;DR the problem in http.csharp.handlebars file or in HeaderBindingConfiguration class.

The condition is no longer relevant most likely
{{#if HeaderBindingConfiguration.Enabled}} because Enabled property no longer exists.

I revised the commit 9f718e4 and as we can see, the Enabled property has been removed from the HeaderBindingConfigurationclass, but http.csharp.handlebars file still has a check of this property.

I can suggest to return this property for example as follows:
public bool Enabled => PropertyFromHeaderMappings.Any();
i don't know how Handlebars and Mustache works under the hood but maybe this can have a positive impact on the performance.

Or just simply remove {{#if HeaderBindingConfiguration.Enabled}} from template because {{#if HeaderBindingConfiguration}} true only when the HttpFunctionOptionsBuilder<TCommand>.AddHeaderMapping was called.

Hopefully this helps

from functionmonkey.

Thanks both - I'll look to get this fixed in the next build!

from functionmonkey.

Resolved in release v0.23.0

from functionmonkey.