CollectionRowBlock property name inconsistency about notion-py HOT 5 CLOSED

Note that the slugified name can already be accessed as a property: row.license_s. But that's not amenable to passing in the non-slugified name. But adding __getitem__ could be good too, if you would find that idiom useful! I don't see any issues with it, and it would allow use of versions of the name that can't be used as property names directly.

PR's welcome for this! (see below)

from notion-py.

Another note: row.get("...") is very different from row.get_property. The data structure for a page (in this case, a collection row) is something like:

In [22]: row.get()                                                                                                                                                                                                                             
Out[22]: 
{'alive': True,
 'created_by': 'f86b4884-75fd-41ba-9161-2fad359c775e',
 'created_time': 1545009470407,
 'id': 'd7f9a19a-b595-49c0-a2ae-58e7d5248a67',
 'last_edited_by': 'f86b4884-75fd-41ba-9161-2fad359c775e',
 'last_edited_time': 1557276849563,
 'parent_id': '02a32a6b-aee3-4868-b2f9-01da7ec88686',
 'parent_table': 'collection',
 'properties': {'f=DE': [['QQQ']], 'title': [['My title']], 'vFY4': [['No']]},
 'type': 'page',
 'version': 22}

The get method reads data from this top-level dict. So you can do row.get("version") to get 22. The get_property method, on the other hand, pokes inside the properties subkey, and provide a bunch of assistance with making it less painful (converting human-readable property names into the underlying 4-character "property ID", converting internal value data formats into Pythonic data, etc). So I think it would actually be best to avoid adding additional interfaces onto these data structures, since it might just compound the complexity.

from notion-py.

Instead, I'll go back and fix the original issue being reported here. :)

It looks as if get_all_properties didn't do full slugification, which is the source of the inconsistency. Fixing that shortly!

from notion-py.

Fixed in #23, which will shortly be released as 0.0.21!

from notion-py.

Version 0.0.21 has now been released to PyPI! Please give it a try and see how it works for you. Thanks for reporting issues!

from notion-py.