Git Product home page Git Product logo

Comments (10)

JakobOvrum avatar JakobOvrum commented on August 24, 2024

I have a few test cases reproducing this one for my system, but it depends on the DLL you link to; the code you provided works fine for me for example.

It's a pretty serious issue though and I'm not sure how to best fix it. Porting all of Lua to D is one option. I suppose recompiling the Lua DLL with the proper flags is another option?

from luad.

MartinNowak avatar MartinNowak commented on August 24, 2024

For me that simple example works with LuaJIT but not with my installed Lua-5.1.4.
For other examples it's vice versa.

As http://pgl.yoyo.org/luai/i/lua_atpanic says you may escape
with a longjmp something along this line would work.

// untested
void* stacktop;
auto wrap_call(alias func, Args...)(auto ref Args args)
{
    asm { mov stacktop, ESP; }
    return func(args);
}

extern(C) void onPanic()
{
    asm { mov ESP, stacktop; }
    throw new Exception("");
}

void doString()
{
    ...
    wrap_call!lua_pcall(...);
}

After reading http://www.lua.org/pil/24.3.1.html I'm really wondering
why it calls at_panic in the first place because it should be in protected mode.

from luad.

JakobOvrum avatar JakobOvrum commented on August 24, 2024

@dawgfoto, the effort is to make it unroll the D stack on the way up.

If you use pcall, you don't get that. If you use xpcall, you can do the same as the panic function, but with the same problems.

from luad.

belm0 avatar belm0 commented on August 24, 2024

Since this LuaD functionality has known problems I suggest disabling it by default and adding a compile or runtime option to enable.

from luad.

JakobOvrum avatar JakobOvrum commented on August 24, 2024

Some more dialogue concerning this issue can be found at issue #40.

I hope we can keep it centralized here in the future.

from luad.

JakobOvrum avatar JakobOvrum commented on August 24, 2024

I pushed Lua libraries for x86-32 and x86-64 Linux compiled with -fno-omit-frame-pointer, which works around this issue for those platforms. That also fixes the travis build and test run. It's also working for 32-bit Windows.

The D issue for this is 10671.

from luad.

TurkeyMan avatar TurkeyMan commented on August 24, 2024

This issue has just drawn one of my projects to a crashing halt... what workarounds exist?

from luad.

TurkeyMan avatar TurkeyMan commented on August 24, 2024

Why aren't we using pcall and catching the error there? Ideally, we could avoid the panic completely...

from luad.

JakobOvrum avatar JakobOvrum commented on August 24, 2024

The issue is compiler and platform specific. The general fix is to compile Lua with frame pointers intact. Which platform/compiler targets do you have issues with?

from luad.

TurkeyMan avatar TurkeyMan commented on August 24, 2024

I expect compiling with frame pointers intact would have a very high cost on performance...
Right now I'm on Win-x86_64 MSVC2015 + DMD, but this is a cross-platform project, including intended Android/iOS builds. Perhaps if Lua is built with C++ exceptions support?
Are there other known workarounds? SJLJ?

from luad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.