Comments (5)
jonathanmedd
commented on July 29, 2024
Good news. It seems like there is a general consensus to name Private Functions without the Verb-Noun standard, so xRequires is cool.
Have implemented a suggested solution, scoping was a bit of an issue putting private functions in a nested module. It seems like the consensus is to put them in a ps1 file and run the script via a reference in the manifest.
Take a look @chelnak and see what you think before I update all the other functions that need an API check
from powervra.
chelnak
commented on July 29, 2024
Nice job!
What do you think about splitting the private functions out in to their own files? E.g. xRequires.ps1
There would be no functional benifit.. only consistency with the way we present the public functions.
Happy either way.
from powervra.
jonathanmedd
commented on July 29, 2024
Yep, that would make sense. I'll update it and make sure all works well, but I reckon that is the way ahead
from powervra.
jonathanmedd
commented on July 29, 2024
@chelnak Updated. Let me know you are happy with it and I'll update all the functions to use it
from powervra.
jonathanmedd
commented on July 29, 2024
Code has been merged into Develop
from powervra.
Related Issues (20)
- Update Azure Pipeline to support Pull Requests to the master branch
- Unable to Connect-vRAServer with a domain account HOT 5
- Add functionality to publish function md docs to GitHub pages
- Update the build step in CI to include exporting aliases
- Disconnect-vRAServer still references Global variable in comments
- Update CI Pipeline to run step 'Publish Unit Test Results' in the 'Build module' job
- Feature Request - Projects Custom Properties HOT 1
- Connect-vRAServer fails to connect to api.mgmt.cloud.vmware.com
- Consider Implementing Pester CodeCoverage HOT 1
- Get-vRACatalogPrincipal wrong with a list of group HOT 2
- Install fails on PowerShell v7.1.3 with Admin rights requirements
- Connect-vRAServer doesn't work on version 8.3 and newer HOT 2
- Debug trace
- Workflows are referencing vulnerable actions
- Bug in Invoke-vRARestMethod auto-pagination handling when fetching policies
- Deprecated (now removed) auth API endpoint breaks PowervRA Connect-vRAServer HOT 1
- Clear out vRA v7 Issues
- vRA 8.12 Connect-VRAServer URI issue HOT 2
- Vidm Authentication not possible
- Filtering doesn't seem to work correctly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from powervra.