`Unexpected end of JSON input` error when using action vs locally about pyright-action HOT 7 CLOSED

I highly suspect this is a buffering problem with the child process; node's stdio support is really fickle and when I made this action, I had to make a bunch of changes to pyright in order to ensure that it didn't exit before it had a change to write all of its output.

I haven't seen any changes to pyright's CLI output code, so I'm going to guess that this is now a buffering problem on the action's side because it reads the output over stdin. (If it comes to it, I could probably modify pyright to write data via IPC or something; that would probably be a good change no matter what.)

On your local copy, can you pipe the JSON output to a file and then tell me its size in bytes?

from pyright-action.

Sure, looks to be about 700KB.

$ pyright NaviGator/gnc/navigator_controller/nodes/gps_to_baselink_odom.py ... --outputjson --pythonplatform=Linux --pythonversion=3.8 > test.json
$ wc -c test.json
727669 

from pyright-action.

Hm, that doesn't seem all that large, really.

Is this repo available for me to test with, by chance?

from pyright-action.

Thanks for looking into this. You should be able to clone our repo (https://github.com/uf-mil/mil) - it's a bit of a monorepo, so it's not super tiny, unfortunately.

We've recently started migrating our Python 2 code to Python 3 on the noetic-migration branch, so you'll just need to check out that branch after cloning. The work done on the GitHub Actions pipeline has been on noetic-ci-improvements, which branched off of noetic-migration a few days ago.

That should be enough to at least run pyright!

from pyright-action.

I was able to copy the command run from your CI task and run it locally; the size of the output for the most recent run is actually ~1.4MB. The default buffer size Node uses for child processes is 1MB, so it's probable that this is part of the problem (the output is so huge). I can try and bump this number up higher and see if that helps, but it's definitely the case that your project is so huge that things are really hitting the limit (especially given pyright uses JSON.stringify to produce its output, which is not streaming).

from pyright-action.

Can you try out v1.4.0, which I've just released?

from pyright-action.

Works like a charm; thank you Jake! Sorry about reporting the incorrect size of the errors earlier.

from pyright-action.