Comments (8)
edbratt
commented on August 21, 2024
Some things you might look at:
1) Have you reviewed the setup instructions in the stand-alone Servlet
TCK user guide
<https://github.com/eclipse-ee4j/jakartaee-tck/tree/master/user_guides/servlet>?
If you haven't already, have a look at section 4.2 Configuring Your
Environment to Repackage and Run the TCK Against the Vendor
Implementation (it's available in adoc format -- you might want to build
the HTML for easier reading. See the readme at the link above).
2) have you checked your results with the test runs at
jenkins.eclipse.org? You might be able to glean something about the
setup and operation, from the successful test results (e.g. build 81).
* The report summary
<https://jenkins.eclipse.org/jakartaee-tck/job/standalonetck-nightly-build-run/lastSuccessfulBuild/junit-reports-with-handlebars/test-summary/8d780f65-fa1e-48a0-b692-e48b05456632.html>
* Last successful build
<https://jenkins.eclipse.org/jakartaee-tck/job/standalonetck-nightly-build-run/lastSuccessfulBuild/>
* Console output
<https://jenkins.eclipse.org/jakartaee-tck/blue/rest/organizations/jenkins/pipelines/standalonetck-nightly-build-run/runs/81/log/?start=0>
I agree that the console log is pretty opaque. Would be nice if someone
were interested in improving the Jenkins output.
3) If you haven't already, have a look at the TCK wiki
<https://github.com/eclipse-ee4j/jakartaee-tck/wiki>. There maybe some
details there, which will be helpful
4) Finally, if you haven't already, you might try a test run against the
Jenkins job that is designed to assist Eclipse GlassFish developers and
can run the suites, according to whatever set of tests you want it to
run (the caveat is, it wants to run Eclipse GlassFish -- but you might
be able to get more details about how these tests are setup and run).
Read the description, here
<https://github.com/eclipse-ee4j/jakartaee-tck/wiki/Project-Specific-JakartaEE-TCK-Run>.
In general, you'd create a pipeline at jenkins.eclipse.org for Servlet
to run the TCK -- you'd need a servlet engine in Eclipse GlassFish (to
start with anyway), configure the test to run -- standalone Servlet TCK
suite only -- tweak the settings until you can see enough details to see
how the test runs -- then use that data to determine what you might want
to change in your PR. Perhaps a bit convoluted, but the advantage being
you'd leave (if you desired) a stand-alone TCK test for the Servlet project.
I hope something in here is helpful.
…-- Ed
On 2/11/2019 10:30 AM, Mark Thomas wrote:
There appear to be two issues.
1. sig-test.map defines |javax.servlet.jsp=2.3_se6| whereas it should
define |javax.servlet.jsp=2.3_se8|
2. |src/com/sun/ts/tests/signaturetest/siganture-repository| does not
exist. It should exist and contain |javax.servlet.jsp.sig_2.3_se8|
The first issue I can fix and can provide a PR. The second I could do
with a pointer on where to look / how to get started.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#48>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/ALtmbiw4Ww4PDEPUKxSv_05OK9-5Kkxmks5vMbbdgaJpZM4a0yoK>.
from platform-tck.
markt-asf
commented on August 21, 2024
-
This bug is for the JSP spec, not the Servlet spec. I have read the relevant docs for the JSP TCK.
-
I get continual 504s from that Jenkins instance at the moment. I'll come back to it as I am curious how the stand-alone TCKs are being run without hitting this bug.
-
I have read it. It doesn't help.
-
Assuming s/Servlet/JSP/ I don't think that will help as I suspect whatever is allowing 2 to be successful will apply here.
I checked back with the JSP 2.2 TCK that the ASF has access to and what I see there is consistent with my view that there is a packaging problem with the Jakarta EE JSP 2.3 TCK nightly build although it isn't quite as I described above.
-
The current
bin/sig-test.mapis correct but I'd also expect to seebin/sig-test_se6.map,bin/sig-test_se7.mapandbin/sig-test_se8.map. -
src/com/sun/ts/tests/signaturetest/siganture-repositoryshould be present (it is missing) and I'd expect it to containjaxax.el.sig_2.3_se6, javax.servlet.jsp.sig_2.3_se6,jaxax.el.sig_2.3_se7, javax.servlet.jsp.sig_2.3_se7,jaxax.el.sig_2.3_se8and javax.servlet.jsp.sig_2.3_se8`
Because none of the history has been imported for any of the Jakarta EE projects I can't look into what might have changed to cause this problem.
from platform-tck.
bhatpmk
commented on August 21, 2024
We will fix the issue as early as possible.
from platform-tck.
markt-asf
commented on August 21, 2024
Just to note, there is a typo in my original report. The name of the missing directory is src/com/sun/ts/tests/signaturetest/signature-repository
from platform-tck.
alwin-joseph
commented on August 21, 2024
I have made the change for this issue. Will keep a watch if it reoccurs.
from platform-tck.
markt-asf
commented on August 21, 2024
I've confirmed that the signature test in the standalone TCK now runs correctly under Java 8. Could the fix be back-ported to the EE4J8 branch?
I'll note that the JSP 2.3 TCK requires Java 8 to run although the minimum Java version for that spec is Java 6. Having this running on Java 6 is a nice to have and I suspect there are many more important issues to address. Having this running on Java 6 isn't essential. I won't open an issue for it.
from platform-tck.
alwin-joseph
commented on August 21, 2024
The fix is made to both the branches - EE4J & master.
master - 303da3f
EE4J_8 - 423f326
from platform-tck.
markt-asf
commented on August 21, 2024
Thanks. I missed that. Just tested the latest EE4J8 nightly JSP TCK build and all looks good. Tx.
from platform-tck.
Related Issues (20)
- TCK challenge for addressing Jakarta EE 10 Platform TCK signature test failures on Java 21 HOT 3
- 3 EJB30 test failures in Platform TCK 8.0.2 when run in JDK11+ HOT 10
- [tck-challege] Jakarta EE Core TCK's cdi-lite-tck-suite.xml out of sync with CDI's tck-tests.xml HOT 3
- TCK Challenge : Servlet URLClient getRequestedSessionIdTest1 test involving session management using URL rewriting doesn't provide option to enable URL rewriting HOT 6
- Add new feature for ignoring classes in java.* via https://github.com/jtulach/netbeans-apitest signature test tool HOT 1
- Revisit htmlunit usage in CDI TCK HOT 3
- TCK failures with refactored JSP TCK HOT 4
- Investigate impact of removing support for optional EJB 2.x features (homes, CIs, etc.) HOT 6
- TCK Challenge for JDBC TCK tests that convert String values like `999999999999999` to Float that fail on Java 21 HOT 8
- Check if any additional licenses are missing from the project LICENSE.md file
- WebSocket TCK 2.2.0 zip is incorrect HOT 1
- WebSocket 2.2.0 TCK is STILL incorrect HOT 1
- Jacc code can be removed from the platform TCK HOT 1
- Use Maven Wrapper HOT 1
- Remove optional TCK tests from the EE 11 Platform TCK
- Staged EL TCK contains reference to unavailable SNAPSHOT version of parent HOT 1
- Staged JSP 4.0.0 TCK has missing dependency (and unexpwected HOT 1
- Staged JSP 4.0.0 TCK has missing dependency and unexpected Maven coordinates HOT 4
- Old DTDs/Schema in deployment descriptors of Tags/Pages/Servlet/Assembly Platform TCK tests HOT 22
- merge master branch changes to tckrefactor branch for EE 11 release
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from platform-tck.