Using sparkledriver with certain dependencies, causes the tests to fail about sparkledriver HOT 6 CLOSED

Just for completeness:

• I don't have any firewalls that would play havoc with the external HTTP calls
• my environment:

OS: OSX 10.11.6

$ java -version
java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)

from sparkledriver.

@dotemacs Ok, I was able to reproduce this only with crypto-random (the other libraries caused no bother). My guess is that crypto-random pulls in a different version of org.apache.commons.codec.digest.DigestUtils that doesn't supply the sha1Hex method, which is causing the jBrowserDriver's cache implementation to throw a java.lang.NoSuchMethodError exception.

from sparkledriver.

@jackrusher thanks for that.

Running lein deps :tree gave me some insight.

Bothring & compojure require crypto-random as a dependency.

But I do experience the failure when I have just ring or just compojure included. Not sure why it passes for you.

I wonder what is it that you do or have setup that doesn't trigger this behaviour for ring & compojure?

Are you using the example repo that I've quoted above or are you using those libraries in some other project?

Thanks

from sparkledriver.

By adding the following:

[commons-codec "1.7"]

dependency, the tests pass even if you include all three libraries: ring, compojure & crypto-random.

I went with 1.7 as the lowest version that it passed with. Obviously going with a higher version ensures that tests pass also.

Should this be included as a dependency in some way in order to prevent other potential users from stumbling upon this issue ? I'm happy to do a pull request but not sure what you think about it.

Thanks

from sparkledriver.

Or maybe just a note in the README ?

Happy to do the PR whichever way you want to go.

from sparkledriver.

I checked out your repo and just ran lein test for each combination of deps. No idea why they all fail for you. Do you have something relevant in your ~/.lein/profiles.clj, maybe?

It looks like the current (highly transitive) dependency for jBrowserDriver is [commons-codec "1.9"], so I'd recommend that one in order to avoid any weirdness upstream. I'm not sure about adding it in sparkledriver, but I would definitely take a PR for the README mentioning the problem/solution.

from sparkledriver.