Git Product home page Git Product logo

Comments (3)

jackc avatar jackc commented on August 20, 2024

That would be an unfortunate occurrence. Changing the type of versionTable would be a breaking interface change -- so I would prefer to avoid that. However, I will change the default from "schema_version" to "public.schema_version".

from tern.

jackc avatar jackc commented on August 20, 2024

I've just pushed v1.9.0. New uses of the CLI should avoid this issue. I also added a comment to the NewMigrator[Ex] functions recommending fully qualifying the version table name.

from tern.

jackc avatar jackc commented on August 20, 2024

Another option to more fully guard against that situation would be to inspect the database and see if there is already a version table in a different schema.

....

Actually, wait a second. In your original scenario, in step 3 the original schema_version table is still visible in the search path. Why is it not just using that?

....

That's the problem... create table if not exists is looking at the top of the search path instead of seeing if a table by that name is visible at all.

So I guess it might be fair to add a check to ensureSchemaVersionTableExists to detect the version table instead of relying on create table if not exists.

...

Okay. Just released v1.9.1 with ensureSchemaVersionTableExists checking for existence of the version table anywhere in the search path instead of only the top. This should resolve the problem regardless of fully qualifying the version table name.

from tern.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.